[issue15376] Refactor the test_runpy walk_package support code into a common location

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Nick Coghlan]

Changes by Nick Coghlan ncogh...@gmail.com:


--
assignee: ncoghlan - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Christie]

Christie added the comment:

@BreamoreBoy, it looks like the next step would be to revisit issue15403 and go 
through the steps outlined by @ncoghlan.

--
nosy: +bobcatfish

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Mark Lawrence]

Mark Lawrence added the comment:

The chain of dependencies goes from here to #15403, #18576 and back here.  How 
do we break this loop?

--
nosy: +BreamoreBoy
type:  - enhancement
versions: +Python 3.5 -Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Nick Coghlan]

Nick Coghlan added the comment:

test.support is now a subpackage in both 3.3 and default, but 
test.support.package_helper still needs to be created (see comments on #15403)

--
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Eric Snow]

Changes by Eric Snow ericsnowcurren...@gmail.com:


--
nosy: +eric.snow

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Nick Coghlan]

Changes by Nick Coghlan ncogh...@gmail.com:


--
assignee:  - ncoghlan

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Nick Coghlan]

Changes by Nick Coghlan ncogh...@gmail.com:


--
dependencies: +Add temp_dir() and change_cwd() to test.support

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Chris Jerdonek]

Chris Jerdonek chris.jerdo...@gmail.com added the comment:

Hi Nick, I was wondering if you'd have time to take a look at the patches I've 
uploaded to issue 15403 and issue 15415 at some point.

Once those are addressed, I think we will be in a much better position to 
address most of this issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Chris Jerdonek]

Chris Jerdonek chris.jerdo...@gmail.com added the comment:

I created issue 15415 and uploaded a patch there with this issue in mind.

test_runpy contains supporting _make_pkg() and _del_pkg() methods that,
among other things, create and delete a temp directory.  That logic
would be better handled by a temp directory context manager.

The patch uploaded to issue 15415 creates such a context manager and
also unit-tests it.  It also reduces the duplication of temp
directory logic between test/script_helper.py and test/support.py.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15376] Refactor the test_runpy walk_package support code into a common location

[Chris Jerdonek]

Chris Jerdonek chris.jerdo...@gmail.com added the comment:

I'm going to address this issue in parts to make it easier to review and see 
what is going on.

The first patch I'm uploading shortly here: issue 15403.  That issue I created 
to address just the file creation part of the code.

The approach I'm taking is to keep the file creation code decoupled from the 
temp directory, sys.path, and import code.  My plan is to address the latter in 
separate patches by creating or modifying existing test support context 
managers, as necessary.

--
dependencies: +Refactor package creation support code into a common location
title: Refactor the create-package code in test_runpy into a helper module - 
Refactor the test_runpy walk_package support code into a common location

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15376
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com