[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Serhiy Storchaka added the comment: Fixed in issue23815. Opened issue26979 for documenting the catch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Serhiy Storchaka added the comment: This change causes a crash when create instances of _tkinter classes (issue23815). If this will not be fixed I suggest to revert the patch. -- ___ Python tracker ___

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Serhiy Storchaka added the comment: _tkinter classes are now heap types and they no longer have the __module__ attribute. >>> import _tkinter >>> _tkinter.TkappType.__module__ Traceback (most recent call last): File "", line 1, in AttributeError: __module__ See issue20204. -- nosy:

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Roundup Robot added the comment: New changeset 4d0c938870bc by Antoine Pitrou in branch 'default': Fix refcounting issue with extension types in tkinter. http://hg.python.org/cpython/rev/4d0c938870bc -- ___ Python tracker

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Antoine Pitrou added the comment: The first two patches (_tkinter_pep3121-384_v0.patch and _tkinter_pep3121-384_v1.patch) seemed to have the refcounts right, but Andrew's further patches lost the required Py_INCREF in the various new() functions (and the corresponding Py_DECREF in deallocs), w

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: No, PEP3121 patch is not ready yet but PEP384 has been applied. -- ___ Python tracker ___ ___ Python

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Mark Lawrence added the comment: Is any more work needed on this issue or can it be closed? -- nosy: +BreamoreBoy ___ Python tracker ___ _

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Changes by Robin Schreiber : -- keywords: +pep3121 -patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Roundup Robot added the comment: New changeset 4eb6e07e8171 by Andrew Svetlov in branch 'default': Issue #15721: apply PEP 384 Refactoring to tkinter module. http://hg.python.org/cpython/rev/4eb6e07e8171 -- ___ Python tracker

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: Amaury, you are right: PyTclObject_Type_slots[3].pfunc = PyObject_GenericGetAttr; is not required. -- ___ Python tracker ___ __

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: Amaury, I completely agree with your objection. I've found this code in xxlimited.c and adapted to _tkinter source. If that weird code can be removed I will do it. I have no idea how we can catch/reproduce the problem, maybe Martin von Loewis can help as autho

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Amaury Forgeot d'Arc added the comment: Andrew, I have questions about the following part of commit bf9d118779f5: + PyTclObject_Type_slots[3].pfunc = PyObject_GenericGetAttr; First, the "3" refers to the position of Py_tp_getattro in the array, which is a fragile thing IMO. Then, this hack wa

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Roundup Robot added the comment: New changeset bf9d118779f5 by Andrew Svetlov in branch 'default': Issue #15721: make _tkinter module pep384 compatible. http://hg.python.org/cpython/rev/bf9d118779f5 -- nosy: +python-dev ___ Python tracker

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: The patch is huge, then I like to apply it in two steps: first implement pep 384 than 3121. Attached first patch. -- Added file: http://bugs.python.org/file27475/_tkinter_pep384_v1.patch ___ Python tracker

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: The patch for current default branch. -- Added file: http://bugs.python.org/file27470/_tkinter_pep3121-384_v7.patch ___ Python tracker ___ _

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: Upload version which check if _tkinter module was destroyed (for example, if it was call from daemon thread runing Tk app when main thread is exiting with interpreter finalization). -- Added file: http://bugs.python.org/file27464/_tkinter_pep3121-384_v

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: Update patch to support TKINTER_PROTECT_LOADTK option. -- Added file: http://bugs.python.org/file27460/_tkinter_pep3121-384_v3.patch ___ Python tracker

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Changes by Andrew Svetlov : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: Submit patch which store own state into module state. Still not finished yet: need to add checks for "ready state" in every access to fields of module state structure. -- assignee: -> asvetlov Added file: http://bugs.python.org/file27458/_tkinter_pep31

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: I'm trying to make patch following myself recommendations. Looks good but not finished yet. Will publish it after all work done. -- ___ Python tracker _

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Robin Schreiber added the comment: Before I submitted this patch, I used to have these variables inside the modulestate, which caused severe problems. I do not know the exact reason, but my guess is that these variables have to be globally available for every thread (tcl variables are used for

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: I would to have all module state inside _tkinterstate structure. static variables like tcl_lock, tcl_state, quitMainLoop, errorInCmd etc should be moved into _tkinterstate also. -- ___ Python tracker

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Andrew Svetlov added the comment: Update patch conforming to current _tkinter code. -- Added file: http://bugs.python.org/file27457/_tkinter_pep3121-384_v1.patch ___ Python tracker _

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Ned Deily added the comment: What version of 10.8 are you seeing those messages with? And do you see them without the patch applied? -- nosy: +ned.deily ___ Python tracker ___

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

Martin v. Löwis added the comment: See http://www.python.org/download/mac/tcltk/ It may be that using a different build of Tcl/Tk solves that problem. -- nosy: +loewis ___ Python tracker _

[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

New submission from Robin Schreiber: Changes proposed in PEP3121 and PEP384 have now been applied to the tkinter module! When running the test form inside Python.exe (tkinter._test()), the litte "test-window" is rendered correctly. However there are still some error messages popping up inside