[issue15861] ttk.Treeview "unmatched open brace in list"

Changes by Serhiy Storchaka : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue15861] ttk.Treeview "unmatched open brace in list"

Serhiy Storchaka added the comment: Fixed. Thank you for report, Bryan Oakley. -- resolution: -> fixed stage: patch review -> committed/rejected ___ Python tracker ___ _

[issue15861] ttk.Treeview "unmatched open brace in list"

Roundup Robot added the comment: New changeset 411bb75be5d1 by Serhiy Storchaka in branch '3.2': Issue #15861: tkinter now correctly works with lists and tuples containing http://hg.python.org/cpython/rev/411bb75be5d1 New changeset 927352d7e994 by Serhiy Storchaka in branch '3.3': Issue #15861:

[issue15861] ttk.Treeview "unmatched open brace in list"

Serhiy Storchaka added the comment: Have you reviewed the patch? Is it good? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue15861] ttk.Treeview "unmatched open brace in list"

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15861] ttk.Treeview "unmatched open brace in list"

Guilherme Polo added the comment: I consider myself the main responsible for this bug, so if the current patch (which I didn't look at) passes all tests, doesn't slow things up (unlikely, I would think) and also works with some more involved styling code then I'm fine with it. These formattin

[issue15861] ttk.Treeview "unmatched open brace in list"

Serhiy Storchaka added the comment: Patch for 2.7 added. -- Added file: http://bugs.python.org/file28287/tkinter_quoting_3-2.7.patch ___ Python tracker ___ __

[issue15861] ttk.Treeview "unmatched open brace in list"

Serhiy Storchaka added the comment: Patch updated. Added additional tests for ttk.Combobox (see issue11290). -- Added file: http://bugs.python.org/file28286/tkinter_quoting_3.patch ___ Python tracker __

[issue15861] ttk.Treeview "unmatched open brace in list"

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28011/tkinter_quoting_2.patch ___ Python tracker ___ ___ Python-bugs-li

[issue15861] ttk.Treeview "unmatched open brace in list"

Serhiy Storchaka added the comment: Patch updated. -- Added file: http://bugs.python.org/file28011/tkinter_quoting_2.patch ___ Python tracker ___

[issue15861] ttk.Treeview "unmatched open brace in list"

Changes by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15861] ttk.Treeview "unmatched open brace in list"

Serhiy Storchaka added the comment: Here is a patch for right quoting of arguments before concatenation. Thanks Bryan Oakley for the analysis. -- keywords: +patch Added file: http://bugs.python.org/file27942/tkinter_quoting.patch ___ Python tracker

[issue15861] ttk.Treeview "unmatched open brace in list"

Stefan Stuhr added the comment: I think this is a case of faulty over-engineering in the ttk module. The following works just fine (imports converted to Python3): import tkinter as tk import tkinter.ttk as ttk root = tk.Tk() tree = ttk.Treeview(root, columns="1 2 3") tree.tk.call(tree, "insert

[issue15861] ttk.Treeview "unmatched open brace in list"

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue15861] ttk.Treeview "unmatched open brace in list"

Zachary Ware added the comment: Just tested on 3.3 and this still happens with that version of Tkinter, which should mean the same happens in 3.2 and 3.4. -- nosy: +zach.ware ___ Python tracker ___

[issue15861] ttk.Treeview "unmatched open brace in list"

Changes by Zachary Ware : -- versions: +Python 3.2, Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue15861] ttk.Treeview "unmatched open brace in list"

Bryan Oakley added the comment: I gave myself an hour or so to play around with this, and the crux of the matter seems to be in the function `_format_optdict()` which converts a dictionary of options and values into something suitable to pass to `tk.call()`. However, I think the same bug is in

[issue15861] ttk.Treeview "unmatched open brace in list"

Ned Deily added the comment: I agree as well. The bigger question is, as Eric suggests, is this the only such case when mapping between Python and Tcl elements? Since Bryan is a well-known Tcl and Tkinter expert, his insights on that would be very useful. --

[issue15861] ttk.Treeview "unmatched open brace in list"

Eric V. Smith added the comment: I agree with Bryan. Further, if the string is being interpreted as Tcl, then this strikes me as a possible injection attack vector (although I'll admit to not having looked at the code to see how the Tcl code is being used and/or interpreted). -- nosy:

[issue15861] ttk.Treeview "unmatched open brace in list"

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue15861] ttk.Treeview "unmatched open brace in list"

Bryan Oakley added the comment: What behavior do I expect? I expect it to not throw an error. I expect whatever string I give to be inserted into the widget unadulterated (ie: if I give the string "foo {" I expect to see "foo {" in the widget). Tkinter is effectively telling me "you have a Tc

[issue15861] ttk.Treeview "unmatched open brace in list"

Ned Deily added the comment: What behavior do you expect? By accident, I found your reply to this StackOverflow question. I take it from that that you think tkinter should be quoting curly braces found in strings. If that is what you mean, can you specify the set of characters that need to

[issue15861] ttk.Treeview "unmatched open brace in list"

New submission from Bryan Oakley: If you try to insert an item into the treeview, give it a tuple of values for the "values" attribute, and one of those values has unbalanced braces, you'll get an error "unmatched open brace in list" To reproduce: import Tkinter as tk import ttk root = tk.Tk