Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
Roundup Robot added the comment:
New changeset 56ed149e597a by Eli Bendersky in branch 'default':
Mention 'make touch' in the devguide.
http://hg.python.org/devguide/rev/56ed149e597a
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
`make touch` was added to the bots in #19106 and is now also recommended in the
devguide for folks running into this problem. IMHO this is all we need here,
because there's no point toiling to make the auto-generation scripts in every
version to work with any
Eli Bendersky added the comment:
Did anyone ended up updating the devguide about this? I can't find anything
related in there.
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
Ezio Melotti added the comment:
I left a review. To test it you could try to reproduce the steps described in
the first message and see what happens.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
Roger Serwy added the comment:
Attached is the updated patch to include Ezio's review. Thanks Ezio!
--
Added file: http://bugs.python.org/file29773/patch_2and3_rev1.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
Ezio Melotti added the comment:
Do you want to provide a patch and test that it works?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
Roger Serwy added the comment:
The attached patch allows the same parser code to run under Python 2 and Python
3. I'm not sure how to test it other than by running the test suite which
passed.
--
Added file: http://bugs.python.org/file29677/patch_2and3.py
Roger Serwy added the comment:
I use Arch Linux which has /usr/bin/python as 3.3.0. I can confirm that touch
Include/Python-ast.h Python/Python-ast.c fixes the problem.
But would it have been simpler just to convert the print statements to
functions so that asdl_c.py would work with Python 3
Ezio Melotti added the comment:
`make touch` is now in 2.7, so the patch should be updated.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
Chris Jerdonek added the comment:
We should be able to add the make touch target to the 2.7 Makefile without
running afoul of the no new features rule.
To keep things simpler, I'm going to create a separate issue for this so that
it can be discussed and committed independently of this
Chris Jerdonek added the comment:
We should be able to add the make touch target to the 2.7 Makefile without
running afoul of the no new features rule.
I created issue 16004 for this: http://bugs.python.org/issue16004
--
___
Python tracker
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
keywords: +needs review
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
Martin v. Löwis added the comment:
Martin meant:
touch Include/Python-ast.h Python/Python-ast.c
No, I *actually* meant 'make touch'.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
Martin v. Löwis added the comment:
Just to clarify, in the original scenario, python did not refer to
anything. From the original comment:
$ python
No such file or directory
So can you find out why asdl_c.py actually printed this error? With no python
executable in PATH, it shouldn't
Chris Jerdonek added the comment:
So can you find out why asdl_c.py actually printed this error?
I collected some additional information. Here is the beginning of
Parser/asdl_c.py:
#! /usr/bin/env python
Generate C code from an ASDL description.
And in the scenario of this issue I have--
Chris Jerdonek added the comment:
Attaching patch.
I started a new section in the FAQ called Build Troubleshooting which is
something Nick suggested in the context of addressing this issue. I'm sure we
could add a couple more questions to this section right now if we wanted to.
--
Chris Jerdonek added the comment:
Adding Nick because he is the one that suggested adding a Build
Troubleshooting section to the devguide FAQ (meant to add him above).
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
We should be able to add the make touch target to the 2.7 Makefile without
running afoul of the no new features rule.
However, agreed this is mostly a docs problem. We're seeing a couple of common
traps that people run into when first getting started, so it
Chris Jerdonek added the comment:
Switching this to a devguide issue so the work-around can be documented, for
example in this section:
http://docs.python.org/devguide/faq.html#how-do-i-switch-between-branches-inside-my-working-copy
--
assignee: - docs@python
components: +Devguide,
Martin v. Löwis added the comment:
The case that python is a Python 3 binary is not a supported installation
(see PEP 394). asdl_c.py works on both 2.x and 3.x unmodified in the 3.x
branch, however, backporting this to 2.7 would be a new feature (support for
building on systems where python
Chris Jerdonek added the comment:
The case that python is a Python 3 binary is not a supported installation
Just to clarify, in the original scenario, python did not refer to anything.
From the original comment:
$ python
No such file or directory
(python2 and python3 did refer to the
Christian Heimes added the comment:
$ make touch
make: *** No rule to make target `touch'. Stop.
Martin meant:
touch Include/Python-ast.h Python/Python-ast.c
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
Chris Jerdonek added the comment:
Yes, that works. Rather than closing this as won't fix, however, I would
suggest that we document the workaround in the devguide.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
New submission from Chris Jerdonek:
Building with--
./configure --with-pydebug make -j2
errors out after switching branches from default to 2.7 when the system Python
is Python 3 (on Mac OS X 10.7.4 using MacPorts).
To reproduce:
$ sudo port select python python32
$ python
No such file or
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
___
Python-bugs-list
Christian Heimes added the comment:
I think this might be related to #15923. It shouldn't be necessary to rebuild
the AST definition unless you have modified the grammar and AST files.
--
nosy: +christian.heimes
___
Python tracker
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15964
___
28 matches
Mail list logo
