Roundup Robot added the comment:
New changeset 3016a9e8061a by Benjamin Peterson in branch '2.7':
PySequence_Fast generally returns a list (#16305)
http://hg.python.org/cpython/rev/3016a9e8061a
--
___
Python tracker rep...@bugs.python.org
Benjamin Peterson added the comment:
(Obviously that last message should have gone to #16395 instead.)
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16305
___
Roundup Robot added the comment:
New changeset 19ed42e84030 by Mark Dickinson in branch '3.3':
Issue #16305: Merge fix from 3.2.
http://hg.python.org/cpython/rev/19ed42e84030
New changeset cbdd6852a274 by Mark Dickinson in branch 'default':
Issue #16305: Merge fix from 3.3.
Mark Dickinson added the comment:
Fixed in 3.2, 3.3 and default. Thanks Amaury for the report and diagnosis!
(I forget to add the issue number in the 3.2 commit: the changeset is
b4bfcf7a4773.)
--
resolution: - fixed
status: open - closed
___
Mark Dickinson added the comment:
I can reproduce this on 3.2 (OS X). I'll take a look tonight.
--
assignee: - mark.dickinson
components: +Extension Modules
priority: normal - high
stage: - needs patch
___
Python tracker rep...@bugs.python.org
Changes by Mark Dickinson dicki...@gmail.com:
--
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16305
___
___
Mark Dickinson added the comment:
Here's a patch.
--
keywords: +patch
stage: needs patch - commit review
Added file: http://bugs.python.org/file27691/fix_factorial_segfault.patch
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
LGTM.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16305
___
___
Python-bugs-list
New submission from Amaury Forgeot d'Arc:
import math, sys
math.factorial(sys.maxsize - 1)
(Hit Ctrl-C)
Segmentation fault
The cause is probably in mathmodule.c::factorial_odd_part():
error:
Py_DECREF(outer);
done:
Py_DECREF(inner);
return outer;
In case of error, the function
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +mark.dickinson, rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16305
___
___
10 matches
Mail list logo