Changes by Ezio Melotti ezio.melo...@gmail.com:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16441
___
___
Roundup Robot added the comment:
New changeset f938d478359a by Chris Withers in branch '2.7':
Bug #16441: avoid excessive memory usage working with large gzip files
http://hg.python.org/cpython/rev/f938d478359a
--
nosy: +python-dev
___
Python tracker
Chris Withers added the comment:
Committed on 2.7 branch.
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16441
___
New submission from Chris Withers:
gzip.py uses range instead of xrange in two places.
This results in excessive memory usage when opening large .gz files.
I actually bumped into this using tarfile.
Am I right in thinking that range basically *is* xrange in 3.x? If so, this bug
applies only to
Jesús Cea Avión added the comment:
Yes, range() in python 3 is equivalent to python 2 xrange().
2.6 is in security only fix mode. So, you only need to fix 2.7.
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
Changes by Jesús Cea Avión j...@jcea.es:
--
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16441
___
___
Python-bugs-list
Chris Withers added the comment:
Okay, here's the patch.
I can't imagine any unit tests are needed or will be impacted by this.
I do have commit rights, am I good to commit this?
--
keywords: +patch
stage: needs patch - patch review
Added file:
Nadeem Vawda added the comment:
Looks good to me. Go ahead.
You needn't add or change any tests for this, but you should run the
existing tests before committing, just to be safe.
--
nosy: +nadeem.vawda
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
Also remember to add a Misc/NEWS entry (and/or run `make patchcheck`) before
committing. If this only affects 2.7 there's no need to merge anything with
3.x, so you can just commit on 2.7 and push.
--
nosy: +ezio.melotti
