[issue16478] Fix division in tabnanny

2012-12-13 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16478] Fix division in tabnanny

2012-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: Applied the patch on all 3 branches and fixed the resource warning in 3.2. Thanks for the report and the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed __

[issue16478] Fix division in tabnanny

2012-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset fc17fdd42c66 by Ezio Melotti in branch '3.2': #16478: use floor division in tabnanny and fix a ResourceWarning. Patch by Serhiy Storchaka. http://hg.python.org/cpython/rev/fc17fdd42c66 New changeset d7558e4015a4 by Ezio Melotti in branch '3.3': #1

[issue16478] Fix division in tabnanny

2012-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: > I can't see a ResourceWarning. A "finally: f.close()" already > exists near the end of the check() method. Looks like it was added in 3.3. -- ___ Python tracker __

[issue16478] Fix division in tabnanny

2012-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > The patch looks OK, buy can you provide a way to reproduce the error (if you > get any)? No, I have not any. I am even not sure tabnanny works at all. But this bug is obvious. So, let's fix it and go on. > Should we add tests for tabnanny? This will be g

[issue16478] Fix division in tabnanny

2012-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: The patch looks OK, buy can you provide a way to reproduce the error (if you get any)? Should we add tests for tabnanny? I tried to get an error from tabnanny but the only thing I got was a ResourceWarning (that can be easily fixed by a finally: f.close() near th

[issue16478] Fix division in tabnanny

2012-11-15 Thread Georg Brandl
Georg Brandl added the comment: Well, sounds reasonable since we're working with an integer number of spaces :) -- ___ Python tracker ___

[issue16478] Fix division in tabnanny

2012-11-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue16478] Fix division in tabnanny

2012-11-15 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Tabnanny should use floor division in calculation, the comment says about this. But in the current Python 3 code "/" was not changed to "//". -- components: Demos and Tools, Library (Lib) files: tabnanny_div.patch keywords: easy, patch messages: 175