Martijn Pieters added the comment:
The 2.7 patch shifted the `itemgetter()` signature to above the `attrgetter()`
change and new notes.
New patch to fix that in issue #17949: http://bugs.python.org/issue17949
--
nosy: +mjpieters
___
Python tracker
Roundup Robot added the comment:
New changeset 6f2412f12bfd by Ezio Melotti in branch '3.3':
#16523: improve attrgetter/itemgetter/methodcaller documentation.
http://hg.python.org/cpython/rev/6f2412f12bfd
New changeset c2000ce25fe8 by Ezio Melotti in branch 'default':
#16523: merge with 3.3.
Ezio Melotti added the comment:
Fixed, thanks for the review!
--
assignee: docs@python - ezio.melotti
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
Attached an updated patch that uses the double signature.
--
stage: patch review - commit review
versions: -Python 3.2
Added file: http://bugs.python.org/file30093/issue16523-2.diff
___
Python tracker
Zachary Ware added the comment:
I left a couple of Rietveld comments. Other than those nitpicks it looks good
to me, and I could be convinced otherwise on the nitpicks :)
Also, thanks for catching the extra commas after the Afters in operator.rst;
I had meant to include those in the same
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: +patch
nosy: +chris.jerdonek
stage: needs patch - patch review
versions: +Python 3.2
Added file: http://bugs.python.org/file28089/issue16523.diff
___
Python tracker rep...@bugs.python.org
Chris Jerdonek added the comment:
+.. function:: attrgetter(attr[, attr2, attr3, ...])
Why not reword to use the *attr notation? It is even already being used below:
+ The function is equivalent to::
def attrgetter(*items):
if any(not isinstance(item, str) for item in
Ezio Melotti added the comment:
I thought about that, but wanted to make a distinction between the form that
accepts only 1 arg and returns an item and the form that receives 2+ args and
returns a tuple.
--
nosy: +ezio.melotti
___
Python tracker
Chris Jerdonek added the comment:
You can also make that distinction using *. For example:
.. function:: attrgetter(attr, *attrs)
or
.. function:: attrgetter(attr)
attrgetter(attr1, attr2, *attrs)
(cf. http://docs.python.org/dev/library/functions.html#max )
Elsewhere we
New submission from R. David Murray:
It looks like the use of the 'args' formal parameter was cut and pasted from
the methodcaller docs, when it is not appropriate for itemgetter and attrgetter.
http://docs.python.org/3/library/operator.html#operator.attrgetter
--
assignee:
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16523
___
___
Python-bugs-list mailing
11 matches
Mail list logo
