Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 2de5c9ced464 by Jesus Cea in branch '2.7':
Issue #1677: Unused variable warning in Non-Windows
http://hg.python.org/cpython/rev/2de5c9ced464
--
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 4de541fbdd58 by Jesus Cea in branch '3.2':
Issue #1677: Unused variable warning in Non-Windows
http://hg.python.org/cpython/rev/4de541fbdd58
New changeset 7937aa6b7e92 by Jesus Cea in branch 'default':
NULL MERGE:
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Python-bugs-list mailing list
Changes by Jesús Cea Avión j...@jcea.es:
--
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Python-bugs-list
Tim Golden m...@timgolden.me.uk added the comment:
And here's the patch against 3.2 (essentially the 2.7 patch but allowing for
the removal of RISCOS support)
--
Added file: http://bugs.python.org/file26207/issue1677-python32.patch
___
Python
Changes by Tim Golden m...@timgolden.me.uk:
Removed file: http://bugs.python.org/file26207/issue1677-python32.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Changes by Tim Golden m...@timgolden.me.uk:
Added file: http://bugs.python.org/file26208/issue1677-python32.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Antoine Pitrou pit...@free.fr added the comment:
Tim, you've got tabs in your 3.3 patch.
Other than that, I wonder why you wait for 100 ms in 3.3 but 10 ms in the other
versions?
--
___
Python tracker rep...@bugs.python.org
Tim Golden m...@timgolden.me.uk added the comment:
Tim, you've got tabs in your 3.3 patch.
Thanks, Antoine. I'll sort that out. (Goodness know how;
none of my editors use tabs).
Other than that, I wonder why you wait for 100 ms in 3.3 but 10 ms in the
other versions?
Ummm. Because they
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset bb4b184e5b33 by Tim Golden in branch '2.7':
Issue #1677: Handle better a race condition between the interactive interpreter
and
http://hg.python.org/cpython/rev/bb4b184e5b33
New changeset 52af10209976 by Tim Golden
Changes by Tim Golden m...@timgolden.me.uk:
--
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Tim Golden m...@timgolden.me.uk added the comment:
Attached is a patch against Python 2.7. It checks in a loop for SIGINT and, if
it still hasn't fired, assumed Ctrl-Z was pressed which generates the same
error.
--
assignee: - tim.golden
keywords: +patch
Added file:
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Shouldn't we be using a proper synchronization primitive? What about waiting
for an event?
--
nosy: +kristjan.jonsson
___
Python tracker rep...@bugs.python.org
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
In fact, there is _PyOS_SigintEvent at the end of signalmodule.c
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Is the ERROR_OPERATION_ABORTED set when Ctrl-Z is hit?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Tim Golden m...@timgolden.me.uk added the comment:
Yep.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Python-bugs-list mailing
Tim Golden m...@timgolden.me.uk added the comment:
To be clear: ERROR_OPERATION_ABORTED is set when Ctrl-Z is hit as the
only thing on a line. If it's just an extra character then it operates
like any other keypress.
--
___
Python tracker
Tim Golden m...@timgolden.me.uk added the comment:
This patch is for 2.7 and does enough to solve the issue without a major
rework. The signal module onthe default branch has had a lot of love
recently and I'll definitely make use of that for a 3.x patch.
--
Kristján Valur Jónsson krist...@ccpgames.com added the comment:
Hm, I wonder if the test for the SIGINT event is required at all.
Could it be sufficient to simply check for the EOF state? EOF would indicate
ctrl z and distinguish it thus from ctrl-c.
--
Tim Golden m...@timgolden.me.uk added the comment:
Nope. Ctrl-C also sets EOF
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Tim Golden m...@timgolden.me.uk added the comment:
And here's a patch for the default branch, using the new sigint event as
Kristan suggested.
--
Added file: http://bugs.python.org/file26202/issue1677-python3x.patch
___
Python tracker
Tim Golden m...@timgolden.me.uk added the comment:
Just to confirm: I can reproduce this more or less consistently on all versions
of Python 2.2 - 3.2 on Windows 7. Those are distribution builds -- ie not
debug builds I've made myself. But it certainly does occur on a debug build of
2.7.
I'm
Tim Golden m...@timgolden.me.uk added the comment:
OK, I've run out of time to look, but the culprit looks like it's an odd
interaction between my_fgets in myreadline.c and the interrupt handler in
signal. There's a section of code which is conditional on
ERROR_OPERATION_ABORTED being
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Great analysis!
... by sleeping for one second ...
Note that Sleep(1) only sleeps for 1 millisecond.
Does the issue go away if you replace with Sleep(10)?
--
___
Python tracker
Tim Golden m...@timgolden.me.uk added the comment:
That'll be my next move when I get some more time.
I've got someone coming over to see me (about real work!)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
Tim Golden m...@timgolden.me.uk added the comment:
OK, it is a race condition between the code in myreadline.c and the
signal_handler in signalmodule.c. It can take between 0 and 3 sleeps for
the myreadline code to see the signal tripped. Patch on its way for 2.7;
VS 2010 downloading so that
Changes by Georg Brandl ge...@python.org:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Python-bugs-list mailing
Changes by Georg Brandl ge...@python.org:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Python-bugs-list mailing
Devin Jeanpierre jeanpierr...@gmail.com added the comment:
For extra clarification, this issue can crop up with even a single press of
ctrl-c. It's not really related to multiple presses, except that pressing it
more increases the odds of it happening.
--
nosy: +Devin Jeanpierre
Christian Heimes li...@cheimes.de added the comment:
Could add a printf() to PC/launcher.c:ctrl_c_handler() to test if the handler
is called in the error case?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
Changes by Mark Hammond skippy.hamm...@gmail.com:
--
nosy: +mhammond
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Python-bugs-list
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
nosy: +santa4nt -Devin Jeanpierre
versions: +Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Devin Jeanpierre jeanpierr...@gmail.com added the comment:
Windows 7 64-bit (on the metal, not in a VM), can confirm. Holding down Ctrl+C
will (eventually) halt Python on all the versions I have installed: 2.3, 2.7,
3.0, 3.1, 3.2. (All of these are 32-bit Pythons). Haven't done anything silly
Brian Curtin cur...@acm.org added the comment:
I'm not able to reproduce this. Do you have anything installed like pyreadline?
--
assignee: ronaldoussoren -
nosy: +brian.curtin
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
I can't reproduce this on windows (in a KVM) with 2.6 or 2.7.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
Isaul Vargas isa...@gmail.com added the comment:
I tested this on a real Windows 7 machine (64 bit, Ultimate)
I open the command prompt, and I have the latest Pythons installed,
Python 2.6.6, Python 2.7 final, and Python 3.1.2
If I hold down Ctrl-C, it will eventually exit the interpreter.
Ronald Oussoren ronaldousso...@mac.com added the comment:
Unassigning this issue from myself as I cannot reproduce the issue on OSX.
--
assignee: ronaldoussoren -
nosy: +ronaldoussoren
___
Python tracker rep...@bugs.python.org
Changes by Ronald Oussoren ronaldousso...@mac.com:
--
nosy: -ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Removing the Windows part: on my machine, repeated Ctrl-C's don't exit the
3.1 interpreter, probably because the io module is now written in C.
--
assignee: - ronaldoussoren
components: +Macintosh -Interpreter Core, Windows
Ronald Oussoren ronaldousso...@mac.com added the comment:
I cannot reproduce this on my machine (running OSX) using 2.5, 2.6 and 3.1
(latest rc).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
Changes by Daniel Diniz aja...@gmail.com:
--
stage: - test needed
versions: +Python 3.1 -Python 2.4, Python 2.5, Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1677
___
Changes by Joseph Armbruster:
--
components: +Windows
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1677
__
___
Python-bugs-list mailing list
Unsubscribe:
Isaul Vargas added the comment:
I wanted to add that this issue also affects python 2.5.1 on the Mac.
Sometimes I may be writing something in the interpreter and I decide to
invalidate my input by pressing Ctrl-C. This will exit the interpreter
occasionally. I think it would be a good idea to
Amaury Forgeot d'Arc added the comment:
I get the same behaviour with python 2.5.1, and even 2.4.4 (on Windows
2000): I hold down Ctrl-C, and after ~30 KeyboardInterrupt, the
interpreter stops.
So this is not 3.0 specific. What is new in python3.0 is that file
objects are implemented in python,
Christian Heimes added the comment:
I don't think it's a critical bug but it may be worth to debug it.
--
keywords: +py3k
nosy: +tiran
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1677
__
New submission from Isaul Vargas:
When running Python 2.5.1 stable in Windows, you can press Ctrl-C as
many times as you want and it will always output Keyboard Interrupt in
the interpreter.
Python 3.0a+ will quit if you press ctrl-c too many times. The last
release of 3.0a2 can handle many
46 matches
Mail list logo
