[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Brett Cannon added the comment: test_importlib now runs both frozen and source code for all relevant tests. Should allow for making changes in the source w/o recompiling and making sure any source tests pass. Also makes sure the pure Python implementation of import that mirrors what import.c does stays compatible. -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed title: Make test_import test_importlib run tests under both _frozen_importlib and importlib._bootstrap - Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Eric Snow added the comment: Hurray! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Brett Cannon added the comment:
It looks like as long as you block _frozen_importlib and do a fresh import of
importlib you can make sure to use the source version of importlib._bootstrap
instead of _frozen_importlib.
from test.support import import_fresh_module
mod = import_fresh_module('importlib.abc', fresh=('importlib',),
blocked=('_frozen_importlib',))
mod
module 'importlib.abc' from
'/Users/bcannon/Repositories/cpython/default/Lib/importlib/abc.py'
mod._bootstrap
module 'importlib._bootstrap' from
'/Users/bcannon/Repositories/cpython/default/Lib/importlib/_bootstrap.py'
mod._frozen_importlib
import importlib
importlib._bootstrap
module 'importlib._bootstrap' (frozen)
mod2 = import_fresh_module('importlib', blocked=('_frozen_importlib',))
mod2
module 'importlib' from
'/Users/bcannon/Repositories/cpython/default/Lib/importlib/__init__.py'
mod2._bootstrap
module 'importlib._bootstrap' from
'/Users/bcannon/Repositories/cpython/default/Lib/importlib/_bootstrap.py'
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16803
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Changes by Brett Cannon br...@python.org: -- assignee: - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16803 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16803 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Ezio Melotti added the comment: Is the usual PEP 399 idiom enough, or is something more advanced required? -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16803 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Brett Cannon added the comment: With some tricky use of import_fresh_module() because importlib.__init__ does some masking trickery, it should ... I think. =) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16803 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16803] Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap
Changes by Brett Cannon br...@python.org: -- title: Make time_importlib run tests under both _frozen_importlib and importlib._bootstrap - Make test_importlib run tests under both _frozen_importlib and importlib._bootstrap ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16803 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
