[issue16902] Add OSS module support for Solaris

Sebastian Wiedenroth added the comment: This patch has also been applied to the python versions shipped by OpenIndiana and OmniOS for a long time. I'd say it's safe to merge. -- nosy: +wiedi ___ Python tracker

[issue16902] Add OSS module support for Solaris

Tim Mooney added the comment: Sooo It's been 3 years. Brian's patch has bit-rotted a bit, but it's easy to update for recent Python. What are the hold-ups to getting this applied? -- ___ Python tracker

[issue16902] Add OSS module support for Solaris

Tim Mooney added the comment: For what it's worth, I've been using a patch nearly identical to this one with python 2.6.x and 2.7.x with good success, and in my case it was under Solaris 10 with the no-cost oss package from 4Front. I now have a new workstation and I've installed OpenIndiana

[issue16902] Add OSS module support for Solaris

brian-cameron-oracle added the comment: Since Modules/ossaudiodev.c has the following line (which is not surrounded by any conditional #ifdef sort of things): #include sys/soundcard.h This means that the OSS plugin will only build on a system that has this header file, so it is safe to check

[issue16902] Add OSS module support for Solaris

New submission from brian-cameron-oracle: Solaris supports OSS, but the attached patch is needed to get it to build. Note that some of the EXPORT_INT lines in Modules/ossaudiodev.c need to be #ifndef'ed out on Sun since OSS on Solaris doesn't support them all. Does it make sense to use

[issue16902] Add OSS module support for Solaris

Jesús Cea Avión added the comment: Brian, is this supported in Solaris 10 or Solaris 11?. How can I actually try it?. I use Solaris on servers, and have Solaris 10/11 virtual machines in my laptop but never ever used sound under Solaris... Also, I am unsure about this being a new feature

[issue16902] Add OSS module support for Solaris

Changes by Trent Nelson tr...@snakebite.org: -- nosy: +trent ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16902 ___ ___ Python-bugs-list mailing

[issue16902] Add OSS module support for Solaris

brian-cameron-oracle added the comment: OSS is the default audio system in Solaris 11 and 12. In Solaris 10 and earlier, the sunaudio (or SADA) interfaces are still used. You can only test this if you are using Solaris 11 or later, on a machine with a sound card supported by OSS. I would

[issue16902] Add OSS module support for Solaris

Jesús Cea Avión added the comment: Brian, then this module should be compiled only under Solaris 11 and up and, presumably, OpenSolaris/Illumos derivatives. Does your patch compiles cleanly under previous Solaris versions?. I am +1 to consider this a bugfix. Any other python-dev opinion? PS:

[issue16902] Add OSS module support for Solaris

brian-cameron-oracle added the comment: Correct, OSS should work out-of-the-box on Solaris 11 and up since it is the default audio system there. OSS was also integrated into OpenSolaris, so it is probably the most sensible audio plugin to use there also. Some end-users may build and install

[issue16902] Add OSS module support for Solaris

Jesús Cea Avión added the comment: The problem with your approach is that different Solaris release could support different flags. So I rather prefer specific #ifdef's. I wonder about compiling OSS module under Solaris without OSS support. Compiling a module acting as NULL is OK, compiling a

[issue16902] Add OSS module support for Solaris

brian-cameron-oracle added the comment: Sure, doing multiple #ifdef's makes sense. Do you need me to provide an updated patch, or is this something easier for someone who has commit access to the source code repository to just go ahead and do. I would think this Module would fail to compile

[issue16902] Add OSS module support for Solaris

Jesús Cea Avión added the comment: Brian, this patch would try to compile OSS module on any Solaris machine, even if not OSS support is provided. That is, compilation would fail in that case. That is not acceptable. Some kind of OSS detection is needed. --

[issue16902] Add OSS module support for Solaris

brian-cameron-oracle added the comment: I'm not sure how to write such OSS detection code. I do know that OSS is only on Solaris systems that have this OSS-specific file: /usr/include/sys/soundcard.h So that's probably the best way to check and it should work even on Solaris 10 if OSS is

[issue16902] Add OSS module support for Solaris

Jesús Cea Avión added the comment: Brian, Linux has that include file too. So, yes, I think that detection would be appropiate. If we could confirm that all platforms with OSS support have that file, we could have something :-). If not, or we are not sure, just check for that file *IF* the

[issue16902] Add OSS module support for Solaris

Jesús Cea Avión added the comment: For user installed packages, the usual path would be /usr/local/include/sys/soundcard.h. So, maybe check both paths. Do you agree? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16902