[issue17143] trace.py uses _warn without importing it

2013-02-19 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 662f97427acf by Ezio Melotti in branch '3.3':
#17143: fix buildbot failures on Windows.
http://hg.python.org/cpython/rev/662f97427acf

New changeset 1bf0ff7db856 by Ezio Melotti in branch 'default':
#17143: merge with 3.3.
http://hg.python.org/cpython/rev/1bf0ff7db856

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-19 Thread Ezio Melotti 

Ezio Melotti added the comment:

This should be fixed now.

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-15 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 3f8b5fcbf07e by Ezio Melotti in branch '3.3':
#17143: fix a missing import in the trace module.  Initial patch by Berker 
Peksag.
http://hg.python.org/cpython/rev/3f8b5fcbf07e

New changeset 46e9f668aea9 by Ezio Melotti in branch 'default':
#17143: merge with 3.3.
http://hg.python.org/cpython/rev/46e9f668aea9

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-15 Thread Ezio Melotti 

Ezio Melotti added the comment:

Fixed, thanks for the report and the patch!

I changed a couple of things:
1) test_deprecated_usage was printing the usage on stderr while running the 
tests -- I changed it to use a StringIO and added a minimal test to check that 
the usage is actually written;
2) there was an unnecessary import warnings that I removed;

FTR this bug was introduced in f1604371240a.

--
assignee:  - ezio.melotti
nosy: +flox
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-15 Thread Ezio Melotti 

Ezio Melotti added the comment:

The windows buildbots are failing with the following error:
ERROR: test_deprecated_find_strings (test.test_trace.TestDeprecatedMethods)
--
Traceback (most recent call last):
  File C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_trace.py, 
line 401, in test_deprecated_find_strings
trace.find_strings(fd.name)
  File C:\buildbot.python.org\3.x.kloth-win64\build\lib\trace.py, line 850, 
in find_strings
return _find_strings(filename, encoding=None)
  File C:\buildbot.python.org\3.x.kloth-win64\build\lib\trace.py, line 422, 
in _find_strings
with open(filename, encoding=encoding) as f:
PermissionError: [Errno 13] Permission denied: 
'c:\\users\\buildbot\\appdata\\local\\temp\\tmp_08yph'

See:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.3/builds/491/steps/test/logs/stdio
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1473/steps/test/logs/stdio

The problem seems to be related to the use of NamedTemporaryFile in 
test_deprecated_find_strings, but doesn't seem to affect 
test_deprecated_find_executable_linenos.

There's also a warning for test_ignored:
test_ignored (test.test_trace.Test_Ignore) ... Not printing coverage data for 
'c:\\users\\buildbot\\appdata\\local\\temp\\tmpwrqs7_': [Errno 13] Permission 
denied: 'c:\\users\\buildbot\\appdata\\local\\temp\\tmpwrqs7_'

This was probably here already, but went unnoticed because it doesn't cause 
failures and it's probably printed in verbose mode only.

--
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-14 Thread Ezio Melotti 

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-14 Thread Ronald Chapman 

Ronald Chapman added the comment:

Islamabad l guythen vkd dudziozl

--
hgrepos: +174
nosy: +Ronald.Chapman

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-14 Thread Ezio Melotti 

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
Removed message: http://bugs.python.org/msg182097

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-14 Thread Ezio Melotti 

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
hgrepos:  -174

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-14 Thread Florent Xicluna 

Changes by Florent Xicluna florent.xicl...@gmail.com:


--
nosy:  -Ronald.Chapman

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-14 Thread Antoine Pitrou 

Antoine Pitrou added the comment:

Eric, do you want to commit?

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-08 Thread Éric Araujo 

Éric Araujo added the comment:

Great patch with tests.

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-07 Thread Antoine Pitrou 

Changes by Antoine Pitrou pit...@free.fr:


--
stage:  - patch review
type:  - behavior
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-06 Thread Dmitry Jemerov 

New submission from Dmitry Jemerov:

trace.py in Python 3.3 standard library uses the _warn function without 
importing it. As a result, an attempt to use a now-deprecated function fails 
with a NameError:

 python3
Python 3.3.0 (v3.3.0:bd8afb90ebf2, Sep 29 2012, 01:25:11) 
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type help, copyright, credits or license for more information.
 import trace
 trace.modname('')
Traceback (most recent call last):
  File stdin, line 1, in module
  File 
/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/trace.py, 
line 827, in modname
_warn(The trace.modname() function is deprecated,
NameError: global name '_warn' is not defined

--
components: Library (Lib)
messages: 181531
nosy: Dmitry.Jemerov
priority: normal
severity: normal
status: open
title: trace.py uses _warn without importing it
versions: Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-06 Thread Dmitry Jemerov 

Dmitry Jemerov added the comment:

Workaround: import warnings; trace._warn = warnings.warn after importing trace

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17143] trace.py uses _warn without importing it

2013-02-06 Thread Berker Peksag 

Berker Peksag added the comment:

Patch attached with tests.

--
keywords: +patch
nosy: +berker.peksag
Added file: http://bugs.python.org/file28979/issue17143.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17143
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com