[issue17277] incorrect line numbers in backtrace after removing a trace function

Change by Atsuo Ishimoto : -- nosy: +ishimoto ___ Python tracker ___ ___

[issue17277] incorrect line numbers in backtrace after removing a trace function

Xavier de Gaye added the comment: The patch is wrong, the frame may not be run by the current PyThreadState. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___

[issue17277] incorrect line numbers in backtrace after removing a trace function

Xavier de Gaye added the comment: The previous patch changed a field in the PyThreadState structure. This new patch is simpler and does not prevent to change f_lineno when it is not the attribute of the frame being traced. The new patch fixes also issue 7238, issue 16482 and issue 17697.

[issue17277] incorrect line numbers in backtrace after removing a trace function

Changes by Nikolaus Rath nikol...@rath.org: -- nosy: +nikratio ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___ ___ Python-bugs-list

[issue17277] incorrect line numbers in backtrace after removing a trace function

Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___ ___ Python-bugs-list

[issue17277] incorrect line numbers in backtrace after removing a trace function

Xavier de Gaye added the comment: The traced_frame.patch fixes also issue 7238 and issue 16482. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___

[issue17277] incorrect line numbers in backtrace after removing a trace function

Xavier de Gaye added the comment: The proposed patch fixes the backtrace line numbers issue, but it does not fix PyFrame_GetLineNumber() which is the recommended way to get the frame line number. As mentionned in the original message, testing for f-f_trace to implement the f_lineno getter is

[issue17277] incorrect line numbers in backtrace after removing a trace function

Xavier de Gaye added the comment: fix the issue by changing PyFrame_GetLineNumber() and the f_lineno accessors The new patch named traced_frame.patch has been uploaded. Also, now it is not allowed anymore to set the f_lineno attribute of a frame that is not the frame being traced, as f_lasti

[issue17277] incorrect line numbers in backtrace after removing a trace function

Xavier de Gaye added the comment: The patch (on the default branch) reverts one of the changes made in r72488 to introduce the new PyFrame_GetLineNumber() function (issue 5954): tb_lineno is now back again the result of the call to PyCode_Addr2Line() instead of the call to

[issue17277] incorrect line numbers in backtrace after removing a trace function

New submission from Xavier de Gaye: It seems that using f_trace in the f_lineno getter PyFrame_GetLineNumber(), as the condition to decide when tracing is active, is incorrect. See the following two examples. In the backtrace printed by tracer.py running with python 3.3, the last entry should

[issue17277] incorrect line numbers in backtrace after removing a trace function

Changes by Xavier de Gaye xdeg...@gmail.com: Added file: http://bugs.python.org/file29163/generator.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___

[issue17277] incorrect line numbers in backtrace after removing a trace function

Changes by Terry J. Reedy tjre...@udel.edu: -- nosy: +belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___ ___ Python-bugs-list

[issue17277] incorrect line numbers in backtrace after removing a trace function

Jesús Cea Avión added the comment: Xavier, could you possibly provide a patch and a test? -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17277 ___