[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: Thank you Xavier! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: New changeset baca85fcc7cdf70af4a76ea0966d4842c173de1a by Serhiy Storchaka (xdegaye) in branch '2.7': [2.7] bpo-17288: Prevent jumps from 'return' and 'exception' trace events. (GH-6111)

[issue17288] cannot jump from a 'return' or 'exception' trace event

Change by Serhiy Storchaka : -- versions: +Python 2.7, Python 3.6 ___ Python tracker ___

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: FWIW I now get github notifications, the problem was some bad configuration of my github profile (my fault). -- ___ Python tracker

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: The conditions used for the fix are still the same in 2.7: f->f_trace == NULL on a call event, f->f_lasti == -1 in a new frame and f->f_stacktop == NULL in a trace function with a non-line event except for yield statements. There are minor

[issue17288] cannot jump from a 'return' or 'exception' trace event

Change by Xavier de Gaye : -- pull_requests: +5874 ___ Python tracker ___ ___

[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: Thank you! Do you mind to make a backport to 2.7 (if this makes a sense)? -- ___ Python tracker

[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: New changeset b8e9d6c5cd44ebc9c462fea9ad1bc5d0b970e28a by Serhiy Storchaka (xdegaye) in branch 'master': bpo-17288: Prevent jumps from 'return' and 'exception' trace events. (GH-6107)

[issue17288] cannot jump from a 'return' or 'exception' trace event

Change by Xavier de Gaye : -- pull_requests: +5870 ___ Python tracker ___ ___

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: In PR 5928 Serhiy Storchaka wrote: > Great! Could you please create a backport to master? Yes. I prefer to answer in the issue as I am still not getting any mail from github. -- ___ Python

[issue17288] cannot jump from a 'return' or 'exception' trace event

miss-islington added the comment: New changeset cf61a81f1d600064be6dd43896afcf5f976de9b0 by Miss Islington (bot) in branch '3.6': [3.7] bpo-17288: Prevent jumps from 'return' and 'exception' trace events. (GH-5928)

[issue17288] cannot jump from a 'return' or 'exception' trace event

Change by miss-islington : -- pull_requests: +5863 ___ Python tracker ___

[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: New changeset e32bbaf376a09c149fa7c7f2919d7c9ce4e2a055 by Serhiy Storchaka (xdegaye) in branch '3.7': [3.7] bpo-17288: Prevent jumps from 'return' and 'exception' trace events. (GH-5928)

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: Serhiy, I have updated the tests for using the jump_test() decorator and replied to your comment about RETURN_VALUE. -- ___ Python tracker

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: Sorry, for some reason github did not send me the emails of your review and I did not think about checking the PR :-( Thanks for your review, I will work on it shortly. -- ___ Python tracker

[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: Thank you Xavier. I had pleasure from reviewing your patch. But please update tests for using the jump_test() decorator. -- ___ Python tracker

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: xdegaye wrote: > An explanation should be given for the behavior of 3.7 and 3.8 in the jump.py > case. In 3.7 when running jump.py as in msg183254, Python aborts with a frame stack overflow. The reason is that when the generator is

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: Actually $ git rebase --onto master 3.7 bpo-17288 fails with one single change in Objects/frameobject.c and one simply needs to (as I have tested it) remove all the three confict markers in this file and remove the following two lines

[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: Usually we create a PR for master (unless the issue is gone here) and backport it to other branches. In this case it may be better to start from 3.7, but it is worth to look at the patch against master for the case if the change

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: Yes, rebase fails merging two changes in Objects/frameobject.c. I can write another PR for master if you want. -- ___ Python tracker

[issue17288] cannot jump from a 'return' or 'exception' trace event

Serhiy Storchaka added the comment: Are there any problems with rebasing it to master? -- ___ Python tracker ___

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: Added PR 5928 for the 3.7 branch. -- ___ Python tracker ___

[issue17288] cannot jump from a 'return' or 'exception' trace event

Change by Xavier de Gaye : -- pull_requests: +5699 ___ Python tracker ___ ___

[issue17288] cannot jump from a 'return' or 'exception' trace event

Xavier de Gaye added the comment: Those are the changes with the current behavior from the behavior in 3.5 observed at the time of the initial bug report: python 3.7: return.pyUnchanged. exception.py After a jump from the 'exception' event into the previous