[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Martin Panter]

Martin Panter added the comment:

Thanks for your feedback. I add a reference to km\ntifs.h in the comment. The 
buildbots seem generally happy with the change. (One timed out in the tests, 
but that seems to be an existing intermittent problem.)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Roundup Robot]

Roundup Robot added the comment:

New changeset e4ddfa61199c by Martin Panter in branch 'default':
Issue #17599: Use unique _Py_REPARSE_DATA_BUFFER etc names to avoid conflict
https://hg.python.org/cpython/rev/e4ddfa61199c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Steve Dower]

Steve Dower added the comment:

I think the WDK is still separate from the Windows SDK, so probably best to 
keep the custom definition with a comment specifying which file it came from 
(so whoever diagnoses an obscure issue in the future can find it quickly).

With the comment, I'm fine with the patch. If you haven't built on MSVC then 
keep an eye on the build bots until it goes through in case something 
unpredictable happens.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Eryk Sun]

Eryk Sun added the comment:

REPARSE_DATA_BUFFER is defined in the WDK filesystem header, km\ntifs.h. It's 
not defined in the user-mode SDK.

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Martin Panter]

Martin Panter added the comment:

Leading underscore is a good idea.

I have no idea if VC14 includes the structure, but I suspect if it was added 
with this name, we would know because it would cause the same conflict that Min 
GW caused.

--
Added file: http://bugs.python.org/file43931/Py_REPARSE.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Steve Dower]

Steve Dower added the comment:

Worth checking if the headers in VC14 have the structure now, as it may 
simplify the whole thing.

If not, I'd add a leading underscore to the name so nobody confuses it for 
public API in the future.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Martin Panter]

Martin Panter added the comment:

Here is a patch implementing my suggestion to unconditionally define 
everything, prefixed with Py_ instead. Not tested on a normal Windows build.

--
versions: +Python 3.6 -Python 3.4
Added file: http://bugs.python.org/file43907/Py_REPARSE.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Martin Panter]

Martin Panter added the comment:

Would it be better to define all the things in "winreparse.h" with names that 
are less likely to conflict, say Py_REPARSE_DATA_BUFFER etc? This would be a 
more general way to avoid conflicts, and also avoid hacking the configure 
script.

Also, is the “#ifndef MAXIMUM_REPARSE_DATA_BUFFER_SIZE” condition necessary?

--
components: +Windows -Cross-Build
nosy: +martin.panter, paul.moore, steve.dower, tim.golden, zach.ware
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Roumen Petrov]

Changes by Roumen Petrov bugtr...@roumenpetrov.info:


Added file: 
http://bugs.python.org/file36222/0009-MINGW-detect-REPARSE_DATA_BUFFER.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17599
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17599] mingw: detect REPARSE_DATA_BUFFER

[Roumen Petrov]

New submission from Roumen Petrov:

split of issue3871.

--
components: Build, Cross-Build
files: 0010-MINGW-detect-REPARSE_DATA_BUFFER.patch
keywords: patch
messages: 185660
nosy: rpetrov
priority: normal
severity: normal
status: open
title: mingw: detect REPARSE_DATA_BUFFER
type: enhancement
versions: Python 3.4
Added file: 
http://bugs.python.org/file29632/0010-MINGW-detect-REPARSE_DATA_BUFFER.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17599
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com