Roundup Robot added the comment:
New changeset 07fa1ed0d551 by Christian Heimes in branch 'default':
Issue #18582: fix memory leak in pbkdf2 code
http://hg.python.org/cpython/rev/07fa1ed0d551
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 0a26ef834a49 by Christian Heimes in branch 'default':
Issue #18582: provide a faster C implementation of pbkdf2_hmac that works with
OpenSSL 1.0
http://hg.python.org/cpython/rev/0a26ef834a49
--
___
Roundup Robot added the comment:
New changeset 88fac1574049 by Christian Heimes in branch 'default':
Issue #18582: HMAC_CTX_copy() is not available on OpenSSL 1.0
http://hg.python.org/cpython/rev/88fac1574049
--
___
Python tracker
Roundup Robot added the comment:
New changeset a15fcb847515 by Christian Heimes in branch 'default':
Issue #18582: skip test of _hashlib.pbkdf2_hmac if OpenSSL is not available or
too old
http://hg.python.org/cpython/rev/a15fcb847515
--
___
Python
Christian Heimes added the comment:
Done
--
stage: - patch review
Added file: http://bugs.python.org/file32064/pbkdf2_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Antoine Pitrou added the comment:
The patch looks good at first sight. It still needs docs and tests :)
Just one thing: are we sure PKCS5_PBKDF2_HMAC is defined on old OpenSSL
versions, or does it need a #ifdef?
--
___
Python tracker
Changes by Christian Heimes li...@cheimes.de:
Removed file: http://bugs.python.org/file31067/pbkdf2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Christian Heimes added the comment:
Here is a new patch with tests, documentation and some minor improvements. The
last argument is now called dklen. If dklen is omitted or None than dklen is
set to digest size of the hash algorithm.
--
Added file:
Christian Heimes added the comment:
Fixed copy n' paste bug in docs.
--
Added file: http://bugs.python.org/file32071/pbkdf2_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Changes by Christian Heimes li...@cheimes.de:
Removed file: http://bugs.python.org/file32064/pbkdf2_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Changes by Christian Heimes li...@cheimes.de:
Removed file: http://bugs.python.org/file32070/pbkdf2_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Roundup Robot added the comment:
New changeset 5fd56d6d3fce by Christian Heimes in branch 'default':
Issue #18582: Add 'pbkdf2_hmac' to the hashlib module.
http://hg.python.org/cpython/rev/5fd56d6d3fce
--
nosy: +python-dev
___
Python tracker
Christian Heimes added the comment:
Thanks Antoine!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
Changes by Donald Stufft donald.stu...@gmail.com:
--
nosy: +dstufft
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
___
Python-bugs-list
New submission from Christian Heimes:
The patch is a proof of concept for PBKDF2 support for the OpenSSL variant of
hashlib. It's a thin wrapper around PKCS5_PBKDF2_HMAC() and is deliberately
designed as low level API with bytes and input and output types. High level
wrappers can do the
Changes by Christian Heimes li...@cheimes.de:
Added file: http://bugs.python.org/file31067/pbkdf2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Changes by Christian Heimes li...@cheimes.de:
Removed file: http://bugs.python.org/file31066/pbkdf2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
___
Antoine Pitrou added the comment:
Please use the y* format, not y#.
Also, I would lower-case pbkdf2, just as we already lower-case md5, sha1,
etc.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18582
18 matches
Mail list logo
