[issue18727] test for writing dictionary rows to CSV
Roundup Robot added the comment: New changeset 2502843dbedf by Antoine Pitrou in branch 'default': Issue #18727: improve test coverage of the csv module by testing for DictWriter.writerows. http://hg.python.org/cpython/rev/2502843dbedf -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18727] test for writing dictionary rows to CSV
Antoine Pitrou added the comment: Hi Muhammad, Sorry, I had forgotten about this issue. I have now committed the patch to 3.5. Thanks for your contribution! -- resolution: - fixed stage: patch review - resolved status: open - closed versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18727] test for writing dictionary rows to CSV
Muhammad Jehanzeb added the comment: Sure. Thanks for the comment. I was just trying to be consistent with other tests. However, I updated the patch based on your recommendation. Please have a look at the latest one. -- Added file: http://bugs.python.org/file31365/issue18727_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18727] test for writing dictionary rows to CSV
Antoine Pitrou added the comment: Thanks. One more question: is there a reason you don't simply call getvalue() at the end (rather than seek(0) followed by several readline() calls)? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18727] test for writing dictionary rows to CSV
Antoine Pitrou added the comment: You can probably use a StringIO for the file object, no need to create a temporary file. -- nosy: +pitrou stage: - patch review versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18727] test for writing dictionary rows to CSV
Muhammad Jehanzeb added the comment: Thanks Antoine, Attached is the updated version of patch using StringIO -- Added file: http://bugs.python.org/file31293/issue18727_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18727] test for writing dictionary rows to CSV
New submission from Muhammad Jehanzeb: Test for writing dictionary rows to further enhance the test coverage of CSV lib. -- components: Tests messages: 195083 nosy: brett.cannon, mjehanzeb priority: normal severity: normal status: open title: test for writing dictionary rows to CSV type: enhancement versions: Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18727] test for writing dictionary rows to CSV
Changes by Muhammad Jehanzeb mjehan...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file31279/issue18727.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18727 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
