Eduardo Seabra added the comment:
I've also increased the test coverage of filecmp.py. Don't know if I should
merge my patch with Alex.Volkov's patch. I'm uploading it as a separate patch.
--
nosy: +Eduardo.Seabra
Added file: http://bugs.python.org/file32801/test_filecmp.patch
Alex Volkov added the comment:
HI Vajrasky,
I fixed the typo in a comment and removed WIN32 constant definition from the
code.
I looked at the existing tearDown method, on line 79, it calls shutil.rmtree on
a directory above the files/directories I'm writing my test files, so the
statements
Changes by Alex Volkov avol...@gmail.com:
--
title: Increased test coverage for test_filecmp - Increased test coverage for
filecmp.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18728
___
Vajrasky Kok added the comment:
Hi Alex.
Typo in #Speicify subdirectories to hide.
I think you should not create WIN32 constant. Use this statement instead:
@unittest.skipIf(sys.platform == win32, Not valid on Windows)
I think you should use addCleanup if you want to remove the directories