[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: > Running the file couple of times will make the interpreter fail with: > libgcc_s.so.1 must be installed for pthread_cancel to work See also bpo-44434: "_thread module: Remove redundant PyThread_exit_thread() call to avoid glibc fatal error: libgcc_s.so.1

[issue18748] io.IOBase destructor silence I/O error on close() by default

Yhojann Aguilera added the comment: I hope that when an error occurs, python tells me what the problem is. The abort core error is a problem at a lower level than python because python is not able to recognize or handle the error. The main problem is that I exceeded the maximum number of

[issue18748] io.IOBase destructor silence I/O error on close() by default

Zack Weinberg added the comment: > To be clear: this issue is NOT a bug in Python I don't think that's entirely true. I think CPython needs to be linked against libgcc_s.so, so that this class of application bugs will no longer manifest as interpreter crashes. I filed #37395 for that.

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: > Same problem using Python 3.6.8 on Ubuntu 18.04 LTS. To be clear: this issue is NOT a bug in Python, but a bug in your application. You must fix your application. You can try to run it on Python 3.8 with python3.8 -X dev to get a log on the error. Good

[issue18748] io.IOBase destructor silence I/O error on close() by default

Yhojann Aguilera added the comment: Same problem using Python 3.6.8 on Ubuntu 18.04 LTS. For now, solve this using LD_PRELOAD=libgcc_s.so.1 python3 ... For more details and pocs: https://github.com/WHK102/wss/issues/2 -- nosy: +Yhojann Aguilera versions: +Python 3.6

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: I closed the issue. I consider that the initial issue has been fixed and all related issues have been fixed as well: * Python 3.8 now logs close() exception in file finalizer in development mode (-X dev) and debug mode (./configure --with-pydebug) * I added

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: New changeset c15a682603a47f5aef5025f6a2e3babb699273d6 by Victor Stinner in branch '3.8': bpo-37223: test_io: silence destructor errors (GH-14031) https://github.com/python/cpython/commit/c15a682603a47f5aef5025f6a2e3babb699273d6 --

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: New changeset 4f6f7c5a611905fb6b81671547f268c226bc646a by Victor Stinner in branch 'master': bpo-18748: Fix _pyio.IOBase destructor (closed case) (GH-13952) https://github.com/python/cpython/commit/4f6f7c5a611905fb6b81671547f268c226bc646a --

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by STINNER Victor : -- pull_requests: +13821 pull_request: https://github.com/python/cpython/pull/13952 ___ Python tracker ___

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by STINNER Victor : -- pull_requests: -13234 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: I created bpo-37223: test_io logs Exception ignored in: warnings. -- ___ Python tracker ___ ___

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: Related issue: bpo-37054 "Ignored exceptions in test_memoryio". -- ___ Python tracker ___ ___

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: New changeset bc2aa816620c5e02ad8e94d8514b7e8f3f551ca1 by Victor Stinner in branch 'master': bpo-18748: _pyio.IOBase emits unraisable exception (GH-13512) https://github.com/python/cpython/commit/bc2aa816620c5e02ad8e94d8514b7e8f3f551ca1 --

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by STINNER Victor : -- pull_requests: +13429 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by Karthikeyan Singaravelan : -- pull_requests: +13234 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by Karthikeyan Singaravelan : -- pull_requests: -13228 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18748] io.IOBase destructor silence I/O error on close() by default

Karthikeyan Singaravelan added the comment: Okay, opened issue36918 . Raising PR against that issue. -- ___ Python tracker ___ ___

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: Karthikeyan Singaravelan: Would you mind to open a separated issue for test_urllib warnings? -- ___ Python tracker ___

[issue18748] io.IOBase destructor silence I/O error on close() by default

Karthikeyan Singaravelan added the comment: I was wrong so removing the close call when io_refs gets to zero causes error on test_urllib2 [0] where close is asserted to be True and I only tested test_urllib initially. One another way would be to check for fp.closed in http.client before

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by Karthikeyan Singaravelan : -- pull_requests: +13228 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18748] io.IOBase destructor silence I/O error on close() by default

Karthikeyan Singaravelan added the comment: The ValueError warnings in test_urllib noted in msg340059 feels like an issue with the test where FakeSocket calls close by itself once it's internal io_refs counter is 0 and during destructor again close is called on an already closed object

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: New changeset 472f794a33221ea835a2fbf6c9f12aa2bd66d1b0 by Victor Stinner in branch 'master': bpo-18748: test_io: silence destructor errors (GH-12805) https://github.com/python/cpython/commit/472f794a33221ea835a2fbf6c9f12aa2bd66d1b0 --

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: Maybe the fact that close() exceptions are ignored silently in io.IOBase constructor should be better documented, but I'm not sure where it should be documented. If someone has an idea, please go ahead and write a pull request :-) --

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: I wrote PR 12805 to silence IOBase destructor exceptions in test_io. -- ___ Python tracker ___

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: Is there someone interested to debug remaining "Exception ignored:" logs in test_urllib? test_invalid_redirect (test.test_urllib.urlopen_HttpTests) ... Exception ignored in: Traceback (most recent call last): File

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: To debug remaining "Exception ignored in:" issues, I'm using the following patch: diff --git a/Lib/unittest/case.py b/Lib/unittest/case.py index 972a4658b1..be38af3daa 100644 --- a/Lib/unittest/case.py +++ b/Lib/unittest/case.py @@ -710,6 +710,7 @@ class

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by STINNER Victor : -- pull_requests: +12732 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18748] io.IOBase destructor silence I/O error on close() by default

STINNER Victor added the comment: New changeset 44235041f3b957abd36d3792450c3540aa09e120 by Victor Stinner in branch 'master': bpo-18748: io.IOBase destructor now logs close() errors in dev mode (GH-12786) https://github.com/python/cpython/commit/44235041f3b957abd36d3792450c3540aa09e120

[issue18748] io.IOBase destructor silence I/O error on close() by default

Change by STINNER Victor : -- title: libgcc_s.so.1 must be installed for pthread_cancel to work -> io.IOBase destructor silence I/O error on close() by default ___ Python tracker