Berker Peksag added the comment:
The same typo also needs to be fixed in the 2.7 branch:
http://hg.python.org/cpython/file/2.7/Lib/test/test_set.py#l1618
--
nosy: +berker.peksag
resolution: fixed -
stage: resolved - needs patch
status: closed - open
versions: +Python 2.7
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: tim.peters - terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18944
___
___
Roundup Robot added the comment:
New changeset de6047ea33e6 by Terry Jan Reedy in branch '2.7':
Issue #18944: backport typo fix
http://hg.python.org/cpython/rev/de6047ea33e6
--
___
Python tracker rep...@bugs.python.org
Changes by Terry J. Reedy tjre...@udel.edu:
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18944
New submission from Armin Rigo:
Found a minor mistake in test_set.py. Patch attached.
--
components: Interpreter Core
files: test_set.diff
keywords: patch
messages: 197060
nosy: arigo
priority: normal
severity: normal
status: open
title: Minor mistake in test_set.py
versions: Python
Terry J. Reedy added the comment:
The typo causes 1 test to run 5 times instead of 5 tests 1 each.
After fix, all pass on Win7, 3.4.0a1 (where fix is on line 1675 instead of
1618).
--
nosy: +rhettinger, terry.reedy
___
Python tracker
Changes by Tim Peters t...@python.org:
--
components: +Tests -Interpreter Core
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18944
___
___
Changes by Armin Rigo ar...@users.sourceforge.net:
--
assignee: - tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18944
___
___
Roundup Robot added the comment:
New changeset b6059bac8a9c by Tim Peters in branch '3.3':
Issue 18944: fix a 1-character typo in test_set.py.
http://hg.python.org/cpython/rev/b6059bac8a9c
New changeset 4b64166d5abb by Tim Peters in branch 'default':
Merge 3.3 into default.
Changes by Tim Peters t...@python.org:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18944
___
Tim Peters added the comment:
The fix is obviously correct ;-) - so what next? Armin Terry, I don't know
whether you have commit privileges. If you don't, assign it to me and I'll
commit it.
Removed 3.5 from the Versions list and added 3.3 and 3.4.
--
nosy: +tim.peters
versions:
Terry J. Reedy added the comment:
Just to answer, anyone with Python snake has commit privileges of some sort but
may not be setup to commit to cpython. I suspect Armin found this while review
the test for pypy. I focus mostly on Idle, but on better days, will do little
commits like this.
Tim Peters added the comment:
Right, I should have asked specifically about cpython commit privs ;-) Thanks
for expounding!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18944
___
13 matches
Mail list logo