[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset fa54069eb8c4 by Eli Bendersky in branch '2.7': Close #18945: Add tests for tempfile name collision handling. http://hg.python.org/cpython/rev/fa54069eb8c4 -- resolution: - fixed stage: test needed - committed/rejected status: open - closed

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: I don't object to adding the tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___ ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 63f25483c8f6 by Eli Bendersky in branch '3.3': Issue #18945: Add tests for tempfile name collision handling. http://hg.python.org/cpython/rev/63f25483c8f6 New changeset c902ceaf7825 by Eli Bendersky in branch 'default': Issue #18945: Add tests for

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-13 Thread Eli Bendersky
Eli Bendersky added the comment: Thanks Vlad, committed to 3.3/3.4; would you like to provide the 2.7 patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-13 Thread Vlad Shcherbina
Changes by Vlad Shcherbina vlad.shcherb...@gmail.com: Added file: http://bugs.python.org/file31739/tempfile_collision_tests_27 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-13 Thread R. David Murray
R. David Murray added the comment: We don't generally backport tests unless they are part of a bug fix. It's not a blanket prohibition, but normally the risk of false positives in a maintenance release on platforms not covered by our buildbots outweighs the benefits of adding the tests.

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-13 Thread Eli Bendersky
Eli Bendersky added the comment: On Fri, Sep 13, 2013 at 6:28 AM, R. David Murray rep...@bugs.python.orgwrote: R. David Murray added the comment: We don't generally backport tests unless they are part of a bug fix. It's not a blanket prohibition, but normally the risk of false positives

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-13 Thread R. David Murray
R. David Murray added the comment: If they are part of a bug fix, then sure. That wasn't clear from this issue, though. On the other hand, if the tests in that other issue cover the actual bug, and these have any chance of *introducing* test failures (especially if they are heisenburgs,

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-13 Thread Eli Bendersky
Eli Bendersky added the comment: Benjamin, what do you think? -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-11 Thread Vlad Shcherbina
Changes by Vlad Shcherbina vlad.shcherb...@gmail.com: Added file: http://bugs.python.org/file31730/tempfile_collision_tests.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-11 Thread Vlad Shcherbina
Changes by Vlad Shcherbina vlad.shcherb...@gmail.com: Removed file: http://bugs.python.org/file31697/tempfile_collision_tests.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-09 Thread Vlad Shcherbina
Changes by Vlad Shcherbina vlad.shcherb...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file31697/tempfile_collision_tests.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-07 Thread Ezio Melotti
Ezio Melotti added the comment: Do you want to submit a patch to add tests for these cases? -- nosy: +ezio.melotti stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-07 Thread Vlad Shcherbina
Vlad Shcherbina added the comment: Probably yes, I'm just not sure when I'll get the time. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-07 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +georg.brandl, ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___ ___

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-06 Thread Vlad Shcherbina
New submission from Vlad Shcherbina: I intend to add test for (existing dir)-(new file) collision in http://bugs.python.org/issue18849, but file-file, file-dir and dir-dir collisions are yet to be covered. -- components: Tests messages: 197062 nosy: vlad priority: normal severity:

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-06 Thread Eli Bendersky
Changes by Eli Bendersky eli...@gmail.com: -- nosy: +eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___ ___ Python-bugs-list