Roundup Robot added the comment:
New changeset 1ebf8d5b7d60 by Robert Collins in branch 'default':
Issue #18983: Allow selection of output units in timeit.
https://hg.python.org/cpython/rev/1ebf8d5b7d60
--
nosy: +python-dev
___
Python tracker
Roundup Robot added the comment:
New changeset ed34dd00405e by Robert Collins in branch 'default':
Fix patch attribution for issue 18983.
https://hg.python.org/cpython/rev/ed34dd00405e
--
___
Python tracker rep...@bugs.python.org
Changes by Robert Collins robe...@robertcollins.net:
--
nosy: +rbcollins
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
Berker Peksag added the comment:
I've added a couple of comments on Rietveld.
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Vincent Davis added the comment:
Anything else need to be done on this patch?
--
nosy: +Vincentdavis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Julian Gindi added the comment:
Anything else need to be done on this patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
___
Quentin Pradet added the comment:
The branch appears to exist now.
--
nosy: +Quentin.Pradet
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Julian Gindi added the comment:
What needs to be done to close this one out?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
___
Vajrasky Kok added the comment:
This feature is for Python 3.5. I think, we will not commit anything to Python
3.5 until Python 3.4 branch is created (in other world, released). So, be
patient. :)
--
nosy: +vajrasky
___
Python tracker
Serhiy Storchaka added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
___
Python-bugs-list mailing list
Julian Gindi added the comment:
Just wanted to check in and see if the documentation change I made is
sufficient. I tried to copy the other entries for the command line arguments.
Let me know if I can improve it in any way.
--
___
Python tracker
Julian Gindi added the comment:
Re-uploaded the patch to remove duplication.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
___
Serhiy Storchaka added the comment:
Besides too long line with sys.stderr.write last patch LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Serhiy Storchaka added the comment:
Ah, I forgot. This feature should be documented in Doc/library/timeit.rst.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Julian Gindi added the comment:
Updated documentation and fixed a few lines that were too long.
--
Added file: http://bugs.python.org/file33095/issue18983_v6.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
Julian Gindi added the comment:
Implemented proposed changes to patch. Simplified for-loop and implemented
invalid input test.
--
Added file: http://bugs.python.org/file33058/issue18983_v2.patch
___
Python tracker rep...@bugs.python.org
Julian Gindi added the comment:
Incorporated updates suggested by serhiy.storchaka
--
Added file: http://bugs.python.org/file33064/issue18983_v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
Serhiy Storchaka added the comment:
It will be better to write error message to sys.stderr (see
test_main_exception).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Julian Gindi added the comment:
Updated patch to log to stderr.
--
Added file: http://bugs.python.org/file33066/issue18983_v4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Julian Gindi added the comment:
Added newline after error message.
--
Added file: http://bugs.python.org/file33067/issue18983_v5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Serhiy Storchaka added the comment:
The patch is doubled.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
___
Python-bugs-list mailing
Julian Gindi added the comment:
Whoops. Sorry about that. Super embarrassing.
--
Added file: http://bugs.python.org/file33068/issue18983_v5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
Julian Gindi added the comment:
Just wanted to check to see if there was anything else I should do regarding
this issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
stage: needs patch - patch review
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
Julian Gindi added the comment:
Updated patch to include unit tests.
--
Added file: http://bugs.python.org/file32874/issue18983.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
___
Julian Gindi added the comment:
I created a patch that allows users to specify a time unit output using the
-u flag. Example usage:
python -m timeit -u msec '-.join(str(n) for n in range(100))'
1 loops, best of 3: 0.156 msec per loop
python -m timeit -u sec '-.join(str(n) for n in
New submission from Serhiy Storchaka:
Just an idea. Currently the timeit module in command line automatically choice
most appropriate time unit for human readable output. But this makes the output
less machine readable. I propose to add new option which specifies fixed time
unit (usec, msec,
Antoine Pitrou added the comment:
If you want the output to be machine readable, better go the full way and add a
--json option, IMO.
--
nosy: +pitrou, tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
Jakub Stasiak added the comment:
My 2 cents - I'd split timeit.main function into processing part and argument
parsing + data printing part so that you could use Python to call the first one
to get the actual results (timings, numbers of loops etc.) and then present the
data to the outside
29 matches
Mail list logo
