[issue19851] reload problem with submodule

2013-12-09 Thread Olivier Grisel 

Olivier Grisel added the comment:

I tested the patch on the current HEAD and it fixes a regression introduced 
between 3.3 and 3.4b1 that prevented to build scipy from source with pip 
install scipy.

--
nosy: +Olivier.Grisel

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19851] reload problem with submodule

2013-12-09 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 1d67eb1df5a9 by Eric Snow in branch 'default':
Issue 19851: Fix a regression in reloading submodules.
http://hg.python.org/cpython/rev/1d67eb1df5a9

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19851] reload problem with submodule

2013-12-09 Thread Eric Snow 

Changes by Eric Snow ericsnowcurren...@gmail.com:


--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19851] reload problem with submodule

2013-12-07 Thread Eric Snow 

Eric Snow added the comment:

This is actually a problem with importlib.reload() (which imp.reload() simply 
wraps).  The attached patch provides a test that reproduces the error.  I'll 
work on a fix ASAP.

Interestingly, the kind of failure depends on frozen vs. source importlib:

==
ERROR: test_reload_submodule (test.test_importlib.test_api.Frozen_ReloadTests)
--
Traceback (most recent call last):
  File Lib/test/test_importlib/test_api.py, line 430, in test_reload_submodule
self.init.reload(ham)
  File Lib/importlib/__init__.py, line 161, in reload
methods.exec(module)
  File frozen importlib._bootstrap, line 1134, in exec
AttributeError: 'NoneType' object has no attribute 'name'

==
ERROR: test_reload_submodule (test.test_importlib.test_api.Source_ReloadTests)
--
Traceback (most recent call last):
  File Lib/test/test_importlib/test_api.py, line 430, in test_reload_submodule
self.init.reload(ham)
  File Lib/importlib/__init__.py, line 158, in reload
raise ImportError(msg.format(parent_name), name=parent_name)
ImportError: parent 'spam' not in sys.modules

--

--
keywords: +patch
priority: normal - critical
stage: test needed - needs patch
title: imp.reload problem with submodule - reload problem with submodule
Added file: http://bugs.python.org/file33033/issue19851-test.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19851] reload problem with submodule

2013-12-07 Thread Eric Snow 

Eric Snow added the comment:

Actually, they're both getting the same error:

AttributeError: 'NoneType' object has no attribute 'name'

I forgot to clear the submodule from sys.modules first.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19851] reload problem with submodule

2013-12-07 Thread Eric Snow 

Eric Snow added the comment:

The problem was that importlib.reload() was not passing the parent's __path__ 
to importlib._bootstrap._find_spec().  This was a consequence of us restoring 
the pre-3.3 reload semantics.

Patch attached.  (Note to self: add Misc/NEWS entry)

--
stage: needs patch - patch review
Added file: http://bugs.python.org/file33037/issue19851-fix-reload.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19851] reload problem with submodule

2013-12-07 Thread Eric Snow 

Changes by Eric Snow ericsnowcurren...@gmail.com:


Removed file: http://bugs.python.org/file33033/issue19851-test.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19851] reload problem with submodule

2013-12-07 Thread Nick Coghlan 

Nick Coghlan added the comment:

Patch looks reasonable to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19851
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com