[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Guido van Rossum added the comment: Let's not do this. The time to meddle with Python 2.7 details is long gone. -- resolution: - wont fix status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Changes by Terry J. Reedy tjre...@udel.edu: -- stage: patch review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Serhiy Storchaka added the comment: What is your decision Guido and Benjamin? -- nosy: +gvanrossum ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Changes by Stefan Krah stefan-use...@bytereef.org: -- nosy: -skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Serhiy Storchaka added the comment: Here is a patch with tests. Not all affected methods are tested because not all methods and modules have tests at all. -- Added file: http://bugs.python.org/file34284/getargs_c_unicode_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Antoine Pitrou added the comment: This sounds reasonable to me, but the patch lacks tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Antoine Pitrou added the comment: However, do note that the semantics will end up different from other uses of unicode. e.g.: aa.strip(ub) u'aa' In str.strip(), passing an unicode parameter returns an unicode string. In str.ljust(), passing an unicode parameter will return a byte string. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Terry J. Reedy added the comment:
The behavior of str.strip is not what I would expect from reading
'''str.strip([chars])
Return a copy of the string with the leading and trailing characters
removed.'''
but I guess it is consistent with a general rule that when mixing bytes and
unicode (which was not always), the bytes are latin-1 decoded to unicode.
However, the 'not always' part (str.strip yes, str.ljust no) made Python a bit
inconsistent with itself.
Adding the unicode_literals import made Python more inconsistent with itself.
You can change byte literals to unicode literals, but if you do and you use
one of the stdlib text apis that are bytes only, your program breaks. This
patch moves the inconsistency around a bit but does not remove it. People who
stick with 2.7 will have to live with inconsistency one way or another.
The turtle color issue is quite different in that it involve text names ('red')
or encodings('#aabbcc') for color tuples that are quoted as text in order to be
passed on to tkinter and tk (which wants unicode anyway).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20015
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Serhiy Storchaka added the comment:
However, do note that the semantics will end up different from other uses of
unicode. e.g.:
aa.strip(ub)
u'aa'
And this behavior is weird.
print 'À\n'.strip('\n')
À
print 'À\n'.strip(u'\n')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0:
ordinal not in range(128)
The self argument of str.strip is variable, but the chars argument is almost
always a literal and affected by unicode_literals future.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20015
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Serhiy Storchaka added the comment: Re-opened due to Python-Dev discussion http://comments.gmane.org/gmane.comp.python.devel/146057. -- resolution: invalid - stage: committed/rejected - patch review status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Stefan Krah added the comment: Well, generally I'd be against adding features, but this particular one could be rationalized in the same way as PEP 414. So I'm simply unsure whether the feature should be added, but *if* it's added, it should be backed by a pronouncement either from the RM or Guido. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Terry J. Reedy added the comment: PEP414 was about adding a feature to 3.3 well before the first alpha release. What Guido has recently said about 2.7 is that after 3 1/2 years we should concentrate on build issues such as came up with the new OSX and de-emphasize or even cease fixing bugs. He thinks that by now, people will have worked around the ones that matter. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Terry J. Reedy added the comment: Victor and Stefan are correct. 2.7 is a fixed version of Python. CPython 2.7.z, z = 1, only gets bug (and build) fixes. A 'new 2.7 version' would be 2.8, which will not happen. The fact that you propose to change the unambiguous doc shows that this is an enhancement, not a bugfix. This change would have had to be done in 2.7.0. -- nosy: +terry.reedy resolution: - invalid stage: patch review - committed/rejected status: open - closed type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
New submission from Serhiy Storchaka: In most cases when str object required, unicode object is allowed too. s and z codes (with modifiers) in PyArg_Parse*() accept both str and unicode instances. But c code accepts only 1-character str, not unicode. This makes harder writing version-agnostic code with imported unicode_literals (2.7 functions require bytes literals, 3.x functions require unicode literals) and breaks pickle compatibility (see issue13566). This change will affect: * str.ljust(), str.rjust() and str.center(); * '%c' % char; * mmap.write_byte(); * array constructor and item setter for 'c' type; * datetime.isoformat(); * bsddb.set_re_delim() and bsddb.set_re_pad(); * msvcrt.putch() and msvcrt.ungetch(); * swi.block.padstring(). -- components: Interpreter Core files: getargs_c_unicode.patch keywords: patch messages: 206529 nosy: alexandre.vassalotti, pitrou, serhiy.storchaka priority: normal severity: normal stage: patch review status: open title: Allow 1-character ASCII unicode where 1-character str is required versions: Python 2.7 Added file: http://bugs.python.org/file33193/getargs_c_unicode.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
STINNER Victor added the comment: I don't like the heuristic of ASCII only characters. Accepting that may lead to bugs if later you pass a non-ASCII character. And is it not too late to change that in Python 2.7? Version released 3 years ago and widely used in production. -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Stefan Krah added the comment: I guess it makes porting to Python 3 easier, but can we do this in a stable release? -- nosy: +benjamin.peterson, skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20015] Allow 1-character ASCII unicode where 1-character str is required
Serhiy Storchaka added the comment: I don't like the heuristic of ASCII only characters. Accepting that may lead to bugs if later you pass a non-ASCII character. What behavior you propose for non-ASCII values? And is it not too late to change that in Python 2.7? Version released 3 years ago and widely used in production. Python 3 released 5 years ago, but many peoples still support and write new software on Python 2. While 2.7 in use, new 2.7 versions which help porting and interoperability with Python 3 will be desirable. See also issue19099. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20015 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
