[issue20070] test_urllib2net is run even when the network resource is disabled

2013-12-26 Thread Matthias Klose 

New submission from Matthias Klose:

test_urllib2net is run even when the network resource is disabled, unlike 
test_urllibnet:

run_tests.py -j 1 -w -uall,-network,-urlfetch
...
[349/380/6] test_urllib2net
Resource 'http://www.python.org/' is not available
Resource 'http://www.example.com' is not available
Resource 'http://bitly.com/urllibredirecttest' is not available
Resource 'http://www.imdb.com' is not available
Resource 'http://docs.python.org/2/glossary.html#glossary' is not available
Resource 'ftp://ftp.mirror.nl/pub/gnu/' is not available
Resource 'ftp://ftp.mirror.nl/pub/gnu/' is not available
Resource 'ftp://ftp.mirror.nl/pub/gnu/' is not available
Resource 'ftp://ftp.mirror.nl/pub/gnu/' is not available
Resource 'http://www.python.org' is not available
Resource 'http://www.python.org' is not available
Resource 'http://www.python.org' is not available
Resource 'http://www.python.org' is not available
[350/380/6] test_urllib_response
[351/380/6] test_urllibnet
test_urllibnet skipped -- Use of the 'network' resource not enabled
[352/380/6] test_urlparse
...

--
components: Tests
messages: 206942
nosy: doko
priority: normal
severity: normal
status: open
title: test_urllib2net is run even when the network resource is disabled
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20070
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20070] test_urllib2net is run even when the network resource is disabled

2013-12-26 Thread Matthias Klose 

Changes by Matthias Klose d...@debian.org:


--
nosy: +zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20070
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20070] test_urllib2net is run even when the network resource is disabled

2013-12-26 Thread Matthias Klose 

Matthias Klose added the comment:

this fixes it for me:

--- a/Lib/test/test_urllib2net.py   Wed Dec 25 17:36:20 2013 +0200
+++ b/Lib/test/test_urllib2net.py   Thu Dec 26 17:05:47 2013 +0100
@@ -14,6 +14,8 @@
 except ImportError:
 ssl = None
 
+support.requires(network)
+
 TIMEOUT = 60  # seconds
 
 
@@ -339,5 +341,4 @@
 
 
 if __name__ == __main__:
-support.requires(network)
 unittest.main()

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20070
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20070] test_urllib2net is run even when the network resource is disabled

2013-12-26 Thread Zachary Ware 

Zachary Ware added the comment:

Looks good to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20070
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20070] test_urllib2net is run even when the network resource is disabled

2013-12-26 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset e00bfb70a0c0 by doko in branch 'default':
- Issue #20070: Don't run test_urllib2net when network resources are not
http://hg.python.org/cpython/rev/e00bfb70a0c0

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20070
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20070] test_urllib2net is run even when the network resource is disabled

2013-12-26 Thread Matthias Klose 

Matthias Klose added the comment:

fixed

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20070
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com