Roundup Robot added the comment:
New changeset 6e6532d313a1 by Brett Cannon in branch 'default':
Issue 20152, 22821: Port the fcntl module to Argument Clinic.
https://hg.python.org/cpython/rev/6e6532d313a1
--
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
Finally finished!
I am never trusting Larry to count anything ever again. ;)
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
So I disagree that the code needs to be tweaked before converting to Argument
Clinic. If the Clinic conversion is not adding to the problem then the code
churn is just going to make applying this patch that much harder.
Thanks for the code review regardless,
Serhiy Storchaka added the comment:
If first convert to Argument Clinic then fixing bugs will be much harder.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Serhiy Storchaka added the comment:
About argument names. You have changed argument names and docstrings in any
case (e.g. was op, now code). Why not conform with standard documentation?
This wouldn't add additional code churn if change it now. But will add if
change it later.
--
Brett Cannon added the comment:
Here is a new patch for fcntl. I would like a review since I had to get a bit
tricky to handle the polymorphic arguments for fcntl and ioctl and I don't
think the test suite is that thorough for this module.
--
Added file:
Serhiy Storchaka added the comment:
I found bugs or doubtful code in the fcntl module. They should be fixed before
converting to Argument Clinic.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
Roundup Robot added the comment:
New changeset 5e8b94397f81 by Brett Cannon in branch 'default':
Issue #20152: Convert the cmath module to Argument Clinic.
https://hg.python.org/cpython/rev/5e8b94397f81
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset f7ab0884467e by Brett Cannon in branch 'default':
Issue #20152: Port the array module to Argument Clinic.
https://hg.python.org/cpython/rev/f7ab0884467e
--
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
Only ones left are:
- fcntl
- cmath
Both no longer apply cleanly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Roundup Robot added the comment:
New changeset c2d71f9afa0b by Brett Cannon in branch 'default':
Issue #20152: Convert _multibytecodecs to Argument Clinic.
http://hg.python.org/cpython/rev/c2d71f9afa0b
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 2617db7e43a3 by Brett Cannon in branch 'default':
Issue #20152: Convert the grp module to Argument Clinic.
http://hg.python.org/cpython/rev/2617db7e43a3
--
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
To make it easier to track what is left to commit:
* grp
* spwd
* fcntl
* pyexpat
* array
* cmath [Martin says this no longer applies cleanly]
I should also mention all of these patches probably need to shift to `output
preset file` as well.
--
stage:
Brett Cannon added the comment:
To make it easier to track what is left to commit:
* spwd
* fcntl
* pyexpat
* array
* cmath [Martin says this no longer applies cleanly]
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
Roundup Robot added the comment:
New changeset b3aa30f474c4 by Brett Cannon in branch 'default':
Issue #20152: Port the spwd module to Argument Clinic.
http://hg.python.org/cpython/rev/b3aa30f474c4
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset c48980af7df2 by Brett Cannon in branch 'default':
Issue #20152: Port the pwd module to Argument Clinic.
http://hg.python.org/cpython/rev/c48980af7df2
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 0c2792a8f9db by Brett Cannon in branch 'default':
Issue #20152: Port pyexpat to Argument Clinic.
http://hg.python.org/cpython/rev/0c2792a8f9db
--
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
To make it easier to track what is left to commit:
* fcntl [does not apply cleanly
* array
* cmath [Martin says this no longer applies cleanly]
--
___
Python tracker rep...@bugs.python.org
Changes by Brett Cannon br...@python.org:
--
assignee: larry - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
___
Martin v. Löwis added the comment:
multibytecodec_derby.diff looks fine, please apply.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Martin v. Löwis added the comment:
The cmath patch fails to apply; please update it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file33594/pyexpat_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Brett Cannon added the comment:
Here is pyexpat updated with ErrorString converted (and generally updated to
manage changes now required by AC for class definitions).
--
Added file: http://bugs.python.org/file33827/pyexpat_derby.diff
___
Python
Brett Cannon added the comment:
Should only have two modules left to convert:
Modules/cmathmodule.c: 8 sites
Modules/arraymodule.c: 27 sites
I have already started arraymodule.c; it's just taking a while.
--
assignee: larry - brett.cannon
Changes by Brett Cannon br...@python.org:
--
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
___
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33828/pyexpat_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file33827/pyexpat_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33829/multibytecodec_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file33514/multibytecodec_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33831/array_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Brett Cannon added the comment:
It took a bit of finessing but I managed to convert cmath in a way that didn't
make it worse compared to before AC.
I now consider this part of the derby done and ready for Larry to review.
--
assignee: brett.cannon - larry
Added file:
Brett Cannon added the comment:
Here is fcntl converted. I didn't do fcntl.ioctl as it has a crazy set of
possible signatures which I simply didn't want to deal with.
--
Added file: http://bugs.python.org/file33591/fcntl_derby.diff
___
Python
Brett Cannon added the comment:
Here is pyexpat converted. Couldn't do ErrorString as the 'l' format isn't
supported; issue #20332.
--
Added file: http://bugs.python.org/file33594/pyexpat_derby.diff
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
I'm going to start tackling some of these today and checking them in directly.
If I don't finish I will update the bug with what I didn't get to.
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
Brett Cannon added the comment:
Patch for multibytecodec.c.
Not sure how you calculated locations, Larry, but this file had 11 things to
change, so some other work divisions might be off.
--
Added file: http://bugs.python.org/file33510/multibytecodec_derby.diff
Brett Cannon added the comment:
After finding out that the initial site counts were off I went through and
manually counted each file in this Derby group to get a more accurate idea of
how much work each file would be.
Modules/cmathmodule.c: 8 sites
Modules/arraymodule.c: 27 sites
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33511/grp_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33513/spwd_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33514/multibytecodec_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Removed file: http://bugs.python.org/file33510/multibytecodec_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Changes by Brett Cannon br...@python.org:
Added file: http://bugs.python.org/file33515/pwd_derby.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
Brett Cannon added the comment:
Might pick this up later today (or never), but taking a break for now.
Larry, I have patches for grp, spwd, _multibytecodec, and pwd I'd like you to
give a once-over to make sure I didn't miss anything.
The only one that I think has an obvious improvement is in
Roundup Robot added the comment:
New changeset 1f3242fb0c9c by Brett Cannon in branch 'default':
Issue #20152: import.c now uses Argument Clinic.
http://hg.python.org/cpython/rev/1f3242fb0c9c
--
nosy: +python-dev
___
Python tracker
Brett Cannon added the comment:
Now it's:
Modules/cmathmodule.c: 8 sites
Modules/cjkcodecs/multibytecodec.c: 8 sites
Modules/arraymodule.c: 8 sites
Modules/pyexpat.c: 7 sites
Modules/fcntlmodule.c: 7 sites
Modules/pwdmodule.c: 2 sites
Modules/spwdmodule.c: 1 sites
Changes by Brett Cannon br...@python.org:
--
assignee: larry -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20152
___
___
Python-bugs-list
Larry Hastings added the comment:
(Brett: in order to avoid creating 129 differet issues on the tracker, I'm
bundling files together into groups of 50 sites. You don't have to tackle the
whole list if you don't want to.)
This issue is part of the Great Argument Clinic Conversion Derby,
where
46 matches
Mail list logo
