[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Inada Naoki]

Inada Naoki  added the comment:


New changeset 9e4f2f3a6b8ee995c365e86d976937c141d867f8 by Inada Naoki in branch 
'master':
bpo-20180: Use argument clinic for dict.pop() and dict.popitem() (GH-12792)
https://github.com/python/cpython/commit/9e4f2f3a6b8ee995c365e86d976937c141d867f8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Inada Naoki]

Change by Inada Naoki :


--
pull_requests: +12721

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 65ce60aef150776f884715b4315a10a0d6ae769e by Serhiy Storchaka in 
branch 'master':
bpo-20180: Simplify char_converter in Argument Clinic. (GH-9828)
https://github.com/python/cpython/commit/65ce60aef150776f884715b4315a10a0d6ae769e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +9203

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Raymond Hettinger]

Raymond Hettinger  added the comment:

> Now just the collections module is left from this group.
> Raymond, what would you like done with it WRT AC conversion,
> if at all?

I would like to pass on the collections module.  Having looked at the patch, I 
think the code is currently better as is.

That bring this one Derby to a close.  Congratulations :-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

Now just the collections module is left from this group.

Raymond, what would you like done with it WRT AC conversion, if at all?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Raymond Hettinger]

Raymond Hettinger  added the comment:


New changeset c4bccd3c7617018b1ce16f95840ffe1a890d44df by Raymond Hettinger 
(Tal Einat) in branch 'master':
bpo-20180: convert most of itertoolsmodule.c to use Argument Clinic (GH-9164)
https://github.com/python/cpython/commit/c4bccd3c7617018b1ce16f95840ffe1a890d44df


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Change by Tal Einat :


--
pull_requests: +8607

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Raymond Hettinger]

Raymond Hettinger  added the comment:


New changeset 3286ce4adee85c5ce8ab3ee3089f3cd44a017fd7 by Raymond Hettinger 
(Tal Einat) in branch 'master':
bpo-20180: itertools.groupby Argument Clinic conversion (GH-4170)
https://github.com/python/cpython/commit/3286ce4adee85c5ce8ab3ee3089f3cd44a017fd7


--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

Now that transmogrify is done, the only open question is about itertools and 
collections.

1. Should collections be converted?
2. How to proceed with itertools? There are two PRs ready, with the one just 
for groupby() approved, but not yet reviewed by Raymond Hettinger.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:


New changeset c929df3b96c8d7e7977e581431192be21cdafd19 by Tal Einat in branch 
'master':
bpo-20180: complete AC conversion of Objects/stringlib/transmogrify.h (GH-8039)
https://github.com/python/cpython/commit/c929df3b96c8d7e7977e581431192be21cdafd19


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

See updated PR for Objects/stringlib/transmogrify.h in GH-8039.

--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Change by Tal Einat :


--
pull_requests: +7648

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[INADA Naoki]

INADA Naoki  added the comment:

> IMO we should create new issues for AC conversion of the collections and 
> random modules (assuming they haven't been converted yet), and close this 
> issue.

I agree with you. Let's finish derby.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

IMO we should create new issues for AC conversion of the collections and random 
modules (assuming they haven't been converted yet), and close this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

To enable progressing with this in smaller steps, I created PR 4170 which 
converts only itertools.groupby and the intertnal _grouper with minimal 
required changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Change by Tal Einat :


--
pull_requests: +4139

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

See PR 4117 on GitHub with the itertools AC conversion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Change by Tal Einat :


--
pull_requests: +4087
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Yes, it is. Actually the #include should be before lists of methods and static 
PyTypeObject initializers. I think it is better to move all method lists and 
type initializers to the bottom of the file.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

As far as I can tell, with the creation of a separate clinic/itertools.c.h, the 
typedefs etc. need to be moved to the top of the file so that the #include can 
come after the typedefs and before the rest of the code which references clinic 
output. Is this indeed the way to go?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Keep islice() non-converted. For the r parameter of permutations() use "r: 
object = None".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

What about islice? Does AC now support complex enough signatures to support it? 
If not, should I leave the comment as is?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

All correct. The final patch should be in the form of GitHub PR.

Don't specify the self parameter explicitly, just rename the corresponding 
variable. The rest of the patch LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat  added the comment:

Id be happy to update the itertools patch.

I haven't been following AC work for quite a while. I would expect this to 
entail:

1. applying the patch to the master branch
2. merging any conflicts
3. running the clinic.py script again
4. review the output and compare it to the previous output to make sure things 
look okay

Would you also prefer this in the form of a GitHub PR?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Seems Raymond have changed his mind about using Argument Clinic in itertools 
(msg302908). Tal, do you mind to update your itertools patch and create a pull 
request?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Martin Panter]

Martin Panter added the comment:

For str.format_map(mapping), yes the parsing happens in 
Objects/stringlib/unicode_format.h, but I don’t see that as a big problem. 
Moving this back to “needs patch”, assuming it is okay to convert format_map().

Other than from that, there are just tricky things left like the str() 
constructor, str.format(*args, **kwargs) (see Issue 20291), and the shared code 
in Objects/stringlib/find.h and Objects/stringlib/transmogrify.h. I don’t know 
what to do about those.

--
nosy: +martin.panter
stage: commit review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Roundup Robot]

Roundup Robot added the comment:

New changeset 01b06ca45f64 by INADA Naoki in branch 'default':
Issue #20180: forgot to update AC output.
https://hg.python.org/cpython/rev/01b06ca45f64

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[INADA Naoki]

INADA Naoki added the comment:

Uhhh!  I'm sorry.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Seems you haven't updated generated AC files.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[INADA Naoki]

INADA Naoki added the comment:

Thank you, Martin and Serhiy.

As http://bugs.python.org/issue20180#msg247987 , remained module to converted
is transmogrify.h.

But docstrings of methods in transmogrify.h were moved to bytes_methods.c in 
issue26765.

May I close this issue for now?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Roundup Robot]

Roundup Robot added the comment:

New changeset 27dc9a1c061e by INADA Naoki in branch 'default':
Issue #20180: convert unicode methods to AC.
https://hg.python.org/cpython/rev/27dc9a1c061e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[INADA Naoki]

Changes by INADA Naoki :


Added file: http://bugs.python.org/file46297/unicodeobject.c.v7.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[INADA Naoki]

INADA Naoki added the comment:

Serhiy Storchaka, would you review again?

Merging unicodeobject.c.v5.patch into default branch was almost straightforward.
But there was one place I should rewrite.  Here is the part of diff -u v5.patch 
v6.patch

-- is old docstring w/o AC
+- is current docstring w/o AC
-+ is AC in v5 patch
++ is AC in v6 patch

 -PyDoc_STRVAR(translate__doc__,
 - "S.translate(table) -> str\n\
 -\n\
--Return a copy of the string S, where all characters have been mapped\n\
--through the given translation table, which must be a mapping of\n\
--Unicode ordinals to Unicode ordinals, strings, or None.\n\
--Unmapped characters are left untouched. Characters mapped to None\n\
--are deleted.");
+-Return a copy of the string S in which each character has been mapped\n\
+-through the given translation table. The table must implement\n\
+-lookup/indexing via __getitem__, for instance a dictionary or list,\n\
+-mapping Unicode ordinals to Unicode ordinals, strings, or None. If\n\
+-this operation raises LookupError, the character is left untouched.\n\
+-Characters mapped to None are deleted.");
 -
 -static PyObject*
 +/*[clinic input]
@@ -1194,14 +1271,14 @@
 +
 +Replace each character in the string using the given translation table.
 +
-+Characters not in the translation table are left untouched.
-+
-+Characters mapped to None are deleted.
++The table must implement lookup/indexing via __getitem__, for instance a
++dictionary or list.  If this operation raises LookupError, the character is
++left untouched.  Characters mapped to None are deleted.
 +[clinic start generated code]*/

--
versions: +Python 3.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Unfortunately, I won't be able to review this due to lack of time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[INADA Naoki]

INADA Naoki added the comment:

transmogrify.h uses hack to share docstring.
I can't find straightforward way.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[INADA Naoki]

INADA Naoki added the comment:

Updated patch for unicodeobject.

@taleinat, could you confirm it?

--
nosy: +inada.naoki
Added file: http://bugs.python.org/file46292/unicodeobject.c.v6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

I'll commit #3 (unicodeobject.c) when I first get the chance, which should be 
in a few days.

I'll be happy to improve the rest as needed if someone can find the time to 
review them!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Robert Collins]

Robert Collins added the comment:

Ok, so will someone commit 3), or would you like me to do so? After that it 
sounds like we can move this back to patch review, since there will be nothing 
left ready for commit.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Summary of the current state of this AC conversion derby group:

1) The collections, itertools and random modules should not be converted (at 
least for now).

2) The three example modules should not be converted (Modules/xxlimited.c, 
Modules/xxmodule.c and Modules/xxsubtype.c).

3) The latest unicodeobject.c patch has a LGTM from Serhiy after several rounds 
of review and improvement. This should probably go in at some point.

4) The single PyArg_ParseTuple in find.h should not be converted, since that is 
actually used for more than a single find() method via some precompiler macro 
magic.

5) transmogrify.h can be converted and has a conversion patch, but the patch 
likely needs updating since it is from Jan. 2014.

--
status: pending - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Robert Collins]

Robert Collins added the comment:

So I'm confused. Is this applicable or not? Its in commit review, but there's 
discussion of politics here :(.

--
nosy: +rbcollins
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

For now almost all generated code are written in separate file, so it doesn't 
attract attention (if you believe Argument Clinic).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Stefan Krah]

Stefan Krah added the comment:

 Sadly, for political reasons, it's best that we not convert collections, 
 itertools, or random for now.

Well, there are also technical reasons.  For example, when reviewing a huge 
patch at the beginning of this year, the sections that touched AC took me 10 
times longer to review than the rest.

--
nosy: +skrah

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Here's a new patch for Objects/unicodeobject.c with all of Serhiy's suggestions 
integrated.

--
Added file: http://bugs.python.org/file39190/unicodeobject.c.v4.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Hurrah!

And that seems to be it for this group, since collections, itertools and random 
are not to be converted at this point, as well as the Modules/xx*.c files, and 
the stringlib files probably require overly extensive changes for conversion.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The patch causes a lot of warnings like

Objects/unicodeobject.c: In function ‘unicode_title_impl’:
Objects/unicodeobject.c:10581:5: warning: passing argument 1 of 
‘_PyUnicode_Ready’ from incompatible pointer type [enabled by default]
 if (PyUnicode_READY(self) == -1)
 ^
Objects/unicodeobject.c:1484:1: note: expected ‘struct PyObject *’ but argument 
is of type ‘struct PyUnicodeObject *’
 _PyUnicode_Ready(PyObject *unicode)
 ^

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Version of patch with PyUnicodeObject * warnings fixed.

--
Added file: http://bugs.python.org/file39191/unicodeobject.c.v5.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

unicodeobject.c.v5.patch LGTM.

--
stage: needs patch - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attaching new patch for unicodeobject.c, which supersedes the previous patches.

I've changed the name of the parameter of str.join() to iterable to match the 
docs. (In the previous patch I had changed it from seq to 
iterable_of_strings.)

I also fixed two minor comments on the doc strings from Martin.

With this, AFAIK, unicodeobject.c should be good to go.

--
Added file: http://bugs.python.org/file39169/unicodeobject.c.v3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Larry Hastings]

Larry Hastings added the comment:

Sadly, for political reasons, it's best that we not convert collections, 
itertools, or random for now.  I'll update this issue if the situation changes. 
 Sorry about that!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
components: +Argument Clinic

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Stefan Krah]

Changes by Stefan Krah stefan-use...@bytereef.org:


--
nosy:  -skrah

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Larry Hastings]

Larry Hastings added the comment:

All the Derby patches should only go into trunk at this point.

--
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Martin v . Löwis]

Martin v. Löwis added the comment:

For the unicodeobject changes, see Rietveld. In addition, it produces many cast 
errors from PyUnicodeObject* to PyObject*. Otherwise, it looks fine - please 
apply (after these fixes).

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attached is a complete AC conversion of itertools.

This is a large conversion, so I was extra careful. I even went over the entire 
diff manually to check for any errors. Compilation runs without warnings and 
the entire test suite passes.

Notes:
* I didn't convert itertools.repeat due to the ongoing discussion regarding it.
* I didn't convert itertools.islice since its signature is like range() but 
with an additional first required argument, making it impossible to convert 
properly.
* I didn't convert several __new__ methods because they treat *args similarly 
to zip(): itertools.chain, itertools.product, itertools.zip_longest
* I used Larry's nullable ints patch (see issue20341) for the 'r' parameter 
to itertools.permutations.
* I converted all of the following methods when defined: __new__ (except for 
classes mentioned above), __sizeof__, __reduce__, __setstate__, __copy__, 
__length_hint__

--
Added file: 
http://bugs.python.org/file33749/taleinat.ac_conversion.itertools.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

And at that, I've finished the conversion of this entire Derby group! Woohoo!

(except for itertools.repeat which is pending discussion)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attached nearly complete conversion of Modules/_collectionsmodule.c.

I've converted all functions using PyArg_* functions, including __new__ 
methods, but not deque.__init__.

I'm attaching a separate patch for deque.__init__.

--
Added file: http://bugs.python.org/file33620/_collectionsmodule.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attached a patch converting deque.__init__ in Modules/_collectionsmodule.c, 
which completes the conversion of this file.

This patch depends Larry's first patch in issue20341 (Argument Clinic: add 
nullable ints). This functionality is used to simplify the existing code for 
accepting None for the 'maxlen' argument to deque.__init__. If needed I can 
supply a patch which does not depend on Larry's patch.

--
Added file: 
http://bugs.python.org/file33621/deque_init_with_nullable_Py_ssize_t.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attached is a complete conversion of Modules/_randommodule.c. Three 
_random.Random methods were converted: seed, getrandbits and __new__.

There's was an problem converting _random.Random.__new__. I overcame it cleanly 
and think this patch is good. Details about the problem follow.

issue1486663 made various __new__ methods of built-in classes only do a 
'_PyArg_NoKeywords' check if the type is the class itself, i.e. not for 
sub-classes. This is to allow sub-classes to accept keyword arguments.

This means that for classes that do this, like _random.Random, converting using 
AC makes it so subclasses can't accept keyword arguments (unless the subclasses 
implement __new__ properly).

Still, it is possible to convert _random.Random.__new__ and also override 
__new__ in random.Random (random != _random, and random.Random subclasses 
_random.Random). This way subclasses of the latter can accept keyword 
arguments. Since anyone sub-classing _random.Random instead of random.Random 
can be expected to know to override __new__ or switch to random.Random, I think 
this is a good solution for this case.

The attached patch does as I suggest above and passes all tests in test_random, 
including 'test_random_subclass_with_kwargs' which checks this issue. Just to 
be sure, I also ran the entire test suite, and all tests pass.

--
Added file: http://bugs.python.org/file33625/_randommodule.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attached complete conversion of Modules/xxlimited.c, Modules/xxmodule.c and 
Modules/xxsubtype.c.

There are no tests for these and the code is not used by anything AFAIK, so I 
was extra careful and went over the diffs manually once everything was done.

--
Added file: 
http://bugs.python.org/file33627/xxlimited_xxmodule_xxsubtype_AC_conversion.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Stefan Krah]

Stefan Krah added the comment:

I think we should probably not convert xx*.c. They are for newcomers
who will likely be confused by the additional information overload.

--
nosy: +skrah

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

I thought AC was how all new modules were supposed to be written. If so, the 
example modules should definitely use AC!

Also note that once the generated code is in separate files, the code in the 
origin files will be simpler and clearer.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Stefan Krah]

Stefan Krah added the comment:

The vast majority of C modules are in third-party packages. I doubt that 
external
modules will all use AC. xxmodule.c is about explaining the basic structure of
a C extension.  AC adds nothing to this and obfuscates (IMO) what is going on.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Thanks, Stefan. I hadn't realized that the xx files were targeted mainly a 
third-party developers. In this case, I can see the sense in not converting 
them.

I only wish someone had said something *before* I went ahead and converted 
them...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Stefan Krah]

Stefan Krah added the comment:

 I only wish someone had said something *before* I went ahead and converted 
 them...

Yeah, sorry. It's also just my personal opinion.  BTW, xxmodule did not compile
and there was a warning for xxsubtype.  I just mention it in case these are AC
issues.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Larry Hastings]

Larry Hastings added the comment:

When AC moves from internal-only tool to supported tool we'll want to convert 
the xx stuff.  But yeah I reckon it makes sense to not convert them yet.  The 
list of files is really more here's the list of stuff to check out and convert 
if necessary.  best judgement is always called for.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attaching a new patch for complete conversion of Objects/unicodeobject.c.
This is to replace the previous patch for this file.

This new patch also converts all other possible unicode methods,
including those not using PyArg_* functions. This includes various
methods with no arguments or with one PyObject* argument.

Unicode methods still not converted, probably impossible to convert:
1) The various find methods (index, count, startswith, rfind, etc.),
   because they use a special function
   'stringlib_parse_args_finds_unicode' to parse their arguments
2) format and format_map, since they are defined elsewhere
3) _decimal2ascii, since it is just for debugging

--
Added file: http://bugs.python.org/file33604/unicodeobject.c_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attaching patch for complete conversion of Objects/unicodeobject.c.

Notes:
* maketrans() was already converted
* converting the lstrip, rstrip and strip methods required a small, non-trivial 
change to the code, since they used a common function for argument parsing
* the documentation for replace() now correctly reflects the actual function 
signature
* I rephrased some doc-strings where it was required, and in several places 
moved some of the text into parameter descriptions

--
Added file: http://bugs.python.org/file33578/unicodeobject.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

Attached patch for AC conversion of Objects/stringlib/transmogrify.h.

Converting the functions in this file required changes to Objects/bytesobject.c 
and Objects/bytearrayobject.c. Those changes are in the patch as well. The 
conversion of those files is part of issue20179 (Derby #10). I'm adding a 
comment on that issue as well with a reference to this.

--
Added file: http://bugs.python.org/file33579/transmogrify.h.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Tal Einat]

Tal Einat added the comment:

I'm attaching my conversion of deque.rotate and _count_elements in 
Modules/_collectionsmodule.c.

There remain 3 other functions in that module to be converted.

One is deque_init which returns int; Larry said (on IRC) to hold off with that 
for now.

The other two are dequeiter_new and dequereviter_new, which use the O! format, 
which I am unsure how to handle.

--
keywords: +patch
nosy: +taleinat
Added file: http://bugs.python.org/file33535/_collectionsmodule.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

[Larry Hastings]

New submission from Larry Hastings:

This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.

This issue asks you to change the following bundle of files:
Modules/_collectionsmodule.c: 4 sites
Modules/itertoolsmodule.c: 11 sites
Modules/_randommodule.c: 1 sites
Objects/unicodeobject.c: 14 sites
Modules/xxlimited.c: 4 sites
Modules/xxmodule.c: 5 sites
Modules/xxsubtype.c: 5 sites
Objects/stringlib/find.h: 1 sites
Objects/stringlib/transmogrify.h: 5 sites

Talk to me (larry) if you only want to attack part of a bundle.

For instructions on how to convert a function to work with Argument
Clinic, read the howto:
http://docs.python.org/dev/howto/clinic.html

--
components: Extension Modules
messages: 207636
nosy: larry
priority: normal
severity: normal
stage: needs patch
status: open
title: Derby #11: Convert 50 sites to Argument Clinic across 9 files
type: enhancement
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com