[issue20211] setup.py: do not add invalid header locations

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Got the same issue here on building Python for Android. See 
https://circleci.com/gh/yan12125/python3-android/11 for an example build log. 
/usr/include is erroneously included and leads to build failures:

building 'xxlimited' extension
/home/ubuntu/android-ndk-r13/toolchains/llvm/prebuilt/linux-x86_64/bin/clang 
-target aarch64-none-linux-android -gcc-toolchain 
/home/ubuntu/android-ndk-r13/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64
 --sysroot=/home/ubuntu/android-ndk-r13/platforms/android-21/arch-arm64/usr 
-fPIC -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv 
-O3 -Wall -Wstrict-prototypes -fPIE -fno-integrated-as -fPIE -fno-integrated-as 
-std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter 
-Wno-missing-field-initializers -DPy_LIMITED_API=0x0305 -I../Include 
-I/usr/include -IObjects -IPython -I. 
-I/home/ubuntu/python3-android/build/21-aarch64-linux-android-4.9/usr/include 
-I/home/ubuntu/python3-android/src/cpython/Include 
-I/home/ubuntu/python3-android/src/cpython/build-target -c 
/home/ubuntu/python3-android/src/cpython/Modules/xxlimited.c -o 
build/temp.linux-aarch64-3.7/home/ubuntu/python3-android/src/cpython/Modules/xxlimited.o
In file included from 
/home/ubuntu/python3-android/src/cpython/Modules/xxlimited.c:17:
In file included from ../Include/Python.h:11:
In file included from /usr/include/limits.h:25:
/usr/include/features.h:398:10: fatal error: 'gnu/stubs.h' file not found
#include 
 ^
1 error generated.

The patch looks reasonable and still applies to the default branch. With this 
patch the build is fine: https://circleci.com/gh/yan12125/python3-android/12

--
nosy: +Chi Hsuan Yen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20211] setup.py: do not add invalid header locations

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20211] setup.py: do not add invalid header locations

[Martin Hundebøll]

Martin Hundebøll added the comment:

The patch looks good to me, and works in my setup.

--
nosy: +hundeboll

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20211] setup.py: do not add invalid header locations

[Mark Lawrence]

Mark Lawrence added the comment:

Can we have a patch review on this issue please.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20211
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20211] setup.py: do not add invalid header locations

[STINNER Victor]

Changes by STINNER Victor victor.stin...@gmail.com:


--
nosy: +doko, haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20211
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20211] setup.py: do not add invalid header locations

[Thomas Petazzoni]

New submission from Thomas Petazzoni:

In the cross-compilation case, setup.py incorrectly adds /usr/include to 
self.compiler.include_dirs, and results in the following invalid compilation 
line:

/home/thomas/projets/buildroot/output/host/usr/bin/arm-none-linux-gnueabi-gcc
  -fPIC -Wno-unused-result -Werror=declaration-after-statement -DNDEBUG -g
  -O3 -Wall -Wstrict-prototypes -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
  -D_FILE_OFFSET_BITS=64 -pipe -Os
  -I./Include -I/usr/include -I. -IInclude
  
-I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-gnueabi/sysroot/usr/include
  -I/home/thomas/projets/buildroot/output/build/python3-3.4.0b1/Include
  -I/home/thomas/projets/buildroot/output/build/python3-3.4.0b1
  -c 
/home/thomas/projets/buildroot/output/build/python3-3.4.0b1/Modules/_struct.c
  -o 
build/temp.linux-arm-3.4/home/thomas/projets/buildroot/output/build/python3-3.4.0b1/Modules/_struct.o
cc1: warning: include location /usr/include is unsafe for cross-compilation 
[-Wpoison-system-directories]

The -I/usr/include is wrong when cross compiling, so we disable adding 
INCLUDEDIR and LIBDIR from the host when cross compiling.

--
components: Cross-Build
files: 0001-setup.py-do-not-add-invalid-header-locations.patch
keywords: patch
messages: 207805
nosy: thomas-petazzoni
priority: normal
severity: normal
status: open
title: setup.py: do not add invalid header locations
type: compile error
versions: Python 3.4
Added file: 
http://bugs.python.org/file33393/0001-setup.py-do-not-add-invalid-header-locations.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20211
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com