[issue2053] IDLE - standardize dialogs

Change by Stéphane Wirtel : -- nosy: +cheryl.sabella versions: +Python 3.8 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list

[issue2053] IDLE - standardize dialogs

Terry J. Reedy added the comment: I would rather leave this open for the moment as an information resource. I wrote query.py with a base class and subclasses to standardize asking users for input. So some of the patch may be obsolete, but it does have a catalog of popup uses. The patch

[issue2053] IDLE - standardize dialogs

Tal Einat added the comment: I suggest that we close this issue. IMO the potential benefit is too small relative to the work required, and the interest is too low. -- ___ Python tracker

[issue2053] IDLE - standardize dialogs

Changes by Terry J. Reedy : -- assignee: -> terry.reedy versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.3, Python 3.4 ___ Python tracker

[issue2053] IDLE - standardize dialogs

Changes by Mark Roseman m...@markroseman.com: -- nosy: +markroseman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___ Python-bugs-list

[issue2053] IDLE - standardize dialogs

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___

[issue2053] IDLE - standardize dialogs

Terry J. Reedy added the comment: The patch does two things. 1. It replaces the existing direct rebinding of messagebox functions as methods, such as self.showerror = tkMessageBox.showerror with binding of a double wrapping of the functions. The middle layer is useless and only serves to

[issue2053] IDLE - standardize dialogs

Changes by Todd Rovito rovit...@gmail.com: -- nosy: +Todd.Rovito ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___ Python-bugs-list

[issue2053] IDLE - standardize dialogs

Mark Lawrence added the comment: Bump as IDLE is now being actively developed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___

[issue2053] IDLE - standardize dialogs

Terry J. Reedy added the comment: I have not looked at the details, so cannot currently comment as to whether the idea should be pursued or dropped. Perhaps when Roger is done with overt bugs he will take a look and offer an opinion. -- assignee: kbk - nosy: +roger.serwy versions:

[issue2053] IDLE - standardize dialogs

Ned Deily added the comment: Attached is a refreshed version of the patch against current 2.7 tip. I did a quick visual comparison with the original but make no guarantees that it is totally accurate. I have no plans to work on it further myself. -- nosy: +ned.deily Added file:

[issue2053] IDLE - standardize dialogs

Mark Lawrence breamore...@yahoo.co.uk added the comment: For the record there has been a sizeable thread on python-dev in the last few days regarding IDLE. As a result it is extremely likely that IDLE outstanding issues will be picked up, so please leave this issue open. -- nosy:

[issue2053] IDLE - standardize dialogs

Changes by Terry J. Reedy tjre...@udel.edu: Removed file: http://bugs.python.org/file10140/IDLE_standardize_dialogs.080429.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___

[issue2053] IDLE - standardize dialogs

Changes by Terry J. Reedy tjre...@udel.edu: Removed file: http://bugs.python.org/file10556/IDLE_standardize_dialogs.080609.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___

[issue2053] IDLE - standardize dialogs

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.2 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___

[issue2053] IDLE - standardize dialogs

Tal Einat talei...@gmail.com added the comment: Because of the method of implementation, a dialog can be created without specifying a parent. There was at least one instance of this in IDLE before my patch. This is a bug, since the behavior of the dialog in this instance is obviously

[issue2053] IDLE - standardize dialogs

Guilherme Polo ggp...@gmail.com added the comment: Tal Einat added the comment: ... The process of discussing this patch has taken far, far too long. I can't stand such discussions spanning months (and years!). Please just accept this patch or close it. I'm fed up with this. If the

[issue2053] IDLE - standardize dialogs

Tal Einat talei...@gmail.com added the comment: At this point I would prefer that this patch just be rejected rather than continue discussing it. I can understand IDLE being a low priority, but someone could have just stated that to begin with and I wouldn't have bothered working for hours to

[issue2053] IDLE - standardize dialogs

Guilherme Polo ggp...@gmail.com added the comment: I have reviewed the latest patch now, it is nice in general but I dislike the idea of increasing even more EditorWindow. I would really prefer to put this somewhere else, like.. idlelib/dialogs.py. Also, I'm inclined to remove this master/parent

[issue2053] IDLE - standardize dialogs

Tal Einat talei...@users.sourceforge.net added the comment: The whole point of this patch is to make the EditorWindow's Text widget the default master/parent for its dialogs! IMO this makes sense, since this is a reasonable and intuitive default for such methods of the EditorWindow object. I

[issue2053] IDLE - standardize dialogs

Guilherme Polo ggp...@gmail.com added the comment: I thought the main point of this issue was to define standard functions, methods, classes (or something in that sense), in order to make the creation of tk dialogs uniform across IDLE. Right now it seems reasonable to keep the parent hidden,

[issue2053] IDLE - standardize dialogs

Changes by Daniel Diniz aja...@gmail.com: -- nosy: +gpolo stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2053 ___ ___

[issue2053] IDLE - standardize dialogs

Tal Einat [EMAIL PROTECTED] added the comment: Attaching a new patch against a more recent revision (resolved minor conflict). Only 3 extremely minor changes from previous patch: fixed two more places where the parent was being passed explicitly (no longer required) and changed two tabs -

[issue2053] IDLE - standardize dialogs

Tal Einat [EMAIL PROTECTED] added the comment: After more testing, I discovered a bug which broke Goto Line. Attaching a fixed patch. Added file: http://bugs.python.org/file10555/IDLE_standardize_dialogs.080609.patch ___ Python tracker [EMAIL PROTECTED]

[issue2053] IDLE - standardize dialogs

Changes by Tal Einat [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file10555/IDLE_standardize_dialogs.080609.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 ___

[issue2053] IDLE - standardize dialogs

Tal Einat [EMAIL PROTECTED] added the comment: uploaded a single comprehensive patch file Added file: http://bugs.python.org/file10140/IDLE_standardize_dialogs.080429.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053

[issue2053] IDLE - standardize dialogs

Kurt B. Kaiser [EMAIL PROTECTED] added the comment: Please provide a single patch file. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 __ ___ Python-bugs-list mailing list

[issue2053] IDLE - standardize dialogs

Kurt B. Kaiser added the comment: I would greatly appreciate it if you would slow down and test your patches and use them for an extended period of time (preferably with some other people trying them) before submitting them. It's quite aggravating to start working on one, and even have it

[issue2053] IDLE - standardize dialogs

Changes by Kurt B. Kaiser: Removed file: http://bugs.python.org/file9395/IDLE_standardize_dialogs.080209.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 __ ___

[issue2053] IDLE - standardize dialogs

Changes by Kurt B. Kaiser: Removed file: http://bugs.python.org/file9396/IDLE_standardize_dialogs.080209_2.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 __ ___

[issue2053] IDLE - standardize dialogs

Tal Einat added the comment: Going through the code more thoroughly, found additional places where the standardized dialogs should be used. Also fixed remaining places where these dialogs are used but the parent widget was still being explicitly set to be the text widget, which is now the

[issue2053] IDLE - standardize dialogs

New submission from Tal Einat: In many places in the code, tkMessageBox dialogs were being used directly, with the master (parent) widget being set explicitly to the EditorWindow's text widget. Only in some cases was the focus being set to the text widget afterwards, although in most this is the

[issue2053] IDLE - standardize dialogs

Tal Einat added the comment: Bah, the initial version contained a silly bug in EditorWindow.goto_line_event. Please remove it, and use this version instead. Added file: http://bugs.python.org/file9395/IDLE_standardize_dialogs.080209.patch __ Tracker [EMAIL

[issue2053] IDLE - standardize dialogs

Changes by Christian Heimes: -- assignee: - kbk keywords: +patch priority: - normal type: - rfe versions: -Python 2.5 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 __

[issue2053] IDLE - standardize dialogs

Changes by Christian Heimes: Removed file: http://bugs.python.org/file9394/IDLE_standardize_dialogs.080208.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2053 __ ___