[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Roundup Robot]

Roundup Robot added the comment:

New changeset b110dd3d6cea by Kushal Das in branch 'default':
Issue #21271: Adds new keyword only parameters in reset_mock call
https://hg.python.org/cpython/rev/b110dd3d6cea

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Emanuel Barry]

Changes by Emanuel Barry :


--
resolution:  -> fixed
stage: patch review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Kushal Das]

Kushal Das added the comment:

Fixed in https://hg.python.org/cpython/rev/b110dd3d6cea

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Kushal Das]

Kushal Das added the comment:

Updated patch with the suggestions from Berker.

--
Added file: http://bugs.python.org/file38989/issue21271v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21271
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Kushal Das]

Kushal Das added the comment:

A patch without NEWS and whatsnew update. I will fill them before commit.

The reset_mock function now has two parameters, return_value, and side_effect. 
Passing True value to any of these will reset that attribute.

--
keywords: +patch
Added file: http://bugs.python.org/file38987/issue21271.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21271
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Berker Peksag]

Berker Peksag added the comment:

I left a couple of comments of Rietveld.

--
nosy: +berker.peksag
stage: needs patch - patch review
type: behavior - enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21271
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Kushal Das]

Kushal Das added the comment:

Working on it. Will submit the patch tomorrow.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21271
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Claudiu Popa]

Changes by Claudiu Popa pcmantic...@gmail.com:


--
nosy: +Claudiu.Popa

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21271
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

[Michael Foord]

New submission from Michael Foord:

unittest.mock.Mock.reset_mock deliberately doesn't reset the return_value and 
side_effect. It would be nice if it gained parameters so that it *could*.

--
assignee: michael.foord
components: Library (Lib)
messages: 216588
nosy: kushal.das, michael.foord
priority: normal
severity: normal
stage: needs patch
status: open
title: reset_mock needs parameters to also reset return_value and side_effect
type: behavior
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21271
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com