[issue21307] PEP 466: backport hashlib changes
Roundup Robot added the comment: New changeset 3f73c44b1fd1 by Benjamin Peterson in branch '2.7': PEP 466: backport hashlib algorithm constants (closes #21307) http://hg.python.org/cpython/rev/3f73c44b1fd1 -- nosy: +python-dev resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Donald Stufft added the comment: This Look good to me. +1 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Alex Gaynor added the comment: Uploaded patch adds the algorithm availability constants to the hashlib module. -- components: +Extension Modules keywords: +needs review, patch Added file: http://bugs.python.org/file36436/backport-hashlib.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Gregory P. Smith added the comment: use a frozenset for algorithms_guaranteed. in the docs under more algor... may be available make the two variables link to their docs. you might explicitly mention python 2.7.9 in that paragraph. you probably should use pystring_fromstring imstead of unicode given this is 2.7. On Fri, Aug 22, 2014 at 9:46 AM, Alex Gaynor rep...@bugs.python.org wrote: Alex Gaynor added the comment: Uploaded patch adds the algorithm availability constants to the hashlib module. -- components: +Extension Modules keywords: +needs review, patch Added file: http://bugs.python.org/file36436/backport-hashlib.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Alex Gaynor added the comment: New patch uses PyString_FromString. To the other two points: 1) Python3 uses a mutable set for both of these, any reason for Python2 to be inconsistent? 2) The docs in Python3 don't have this link either, I'm trying to minimize the delta; if you think there should be a link I'd prefer it be done in python3, and then I can backport that as well. -- Added file: http://bugs.python.org/file36439/backport-hashlib.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Gregory P. Smith added the comment: Keeping the delta small makes sense. I'd use frozenset in 3 as well but its unimportant. LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
New submission from Nick Coghlan: Tracker issue for the hashlib PBKDF2 and algorithm availability details backport to 2.7 described in PEP 466. -- messages: 216827 nosy: alex, benjamin.peterson, christian.heimes, dstufft, giampaolo.rodola, janssen, ncoghlan, pitrou priority: normal severity: normal stage: needs patch status: open title: PEP 466: backport hashlib changes type: enhancement versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Alex Gaynor added the comment: issue21304 has the implementation of the PBKDF2 work. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Benjamin Peterson added the comment: Let's dup this then. -- resolution: - duplicate status: open - closed superseder: - Backport hashlib.pbkdf2_hmac to Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Benjamin Peterson added the comment: Rather #21304 should be a dep... -- dependencies: +Backport hashlib.pbkdf2_hmac to Python 2.7 resolution: duplicate - status: closed - open superseder: Backport hashlib.pbkdf2_hmac to Python 2.7 - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21307] PEP 466: backport hashlib changes
Changes by Gregory P. Smith g...@krypto.org: -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21307 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
