[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Changes by Zachary Ware zachary.w...@gmail.com: -- stage: - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Roundup Robot added the comment: New changeset e90024db8d6c by Benjamin Peterson in branch '2.7': openssl requires nasm (#21462) http://hg.python.org/cpython/rev/e90024db8d6c -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Benjamin Peterson added the comment: On Fri, May 30, 2014, at 12:54, Zachary Ware wrote: Zachary Ware added the comment: Looks like the AMD64 buildbot isn't happy with OpenSSL 1.0.1g: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%202.7/builds/1223/steps/compile/logs/stdio Here's my best stab-in-the-dark guess at fixing what's wrong; I don't have the ability to build x64 2.7 handy. Good call. That seems to have satisfied the AMD64 bot (at least in the compile stage). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Roundup Robot added the comment: New changeset 7095a9bfbe76 by Steve Dower in branch '2.7': Issue #21462 PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds http://hg.python.org/cpython/rev/7095a9bfbe76 New changeset 8e2cda42b466 by Benjamin Peterson in branch '2.7': openssl requires nasm (#21462) http://hg.python.org/cpython/rev/8e2cda42b466 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Nick Coghlan added the comment: Will this be in 2.7.7? If so, I'll update the draft What's New changes in issue #21569 accordingly (as well as the implementation status in PEP 466) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Benjamin Peterson added the comment: Yes. On Sat, May 31, 2014, at 11:30, Nick Coghlan wrote: Nick Coghlan added the comment: Will this be in 2.7.7? If so, I'll update the draft What's New changes in issue #21569 accordingly (as well as the implementation status in PEP 466) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Changes by Benjamin Peterson benja...@python.org: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Steve Dower added the comment: I can commit it, though I don't know how it'll affect Benjamin's release branch? (Obviously the build will be fine either way - I had the patch applied for 2.7.7rc1.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Zachary Ware added the comment: Go ahead and commit; it will be up to Benjamin to cherry-pick it to his release branch (or to ask you to do it). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Roundup Robot added the comment: New changeset f6e47d27f67a by Steve Dower in branch '2.7': Issue #21462 PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds http://hg.python.org/cpython/rev/f6e47d27f67a -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Zachary Ware added the comment: Looks like the AMD64 buildbot isn't happy with OpenSSL 1.0.1g: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%202.7/builds/1223/steps/compile/logs/stdio Here's my best stab-in-the-dark guess at fixing what's wrong; I don't have the ability to build x64 2.7 handy. -- Added file: http://bugs.python.org/file35415/224ca86e3919_backport.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Zachary Ware added the comment: Steve or Tim, did one of you want to commit this since you can run a clean test? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Nick Coghlan added the comment: Yes, since OpenSSL 1.0.2 is still in beta, the target version for 2.7.7 would be 1.0.1g -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Changes by Nick Coghlan ncogh...@gmail.com: -- components: +Build title: PEP 466: upgrade OpenSSL - PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Zachary Ware added the comment: Here's all the patch that should be necessary to do the upgrade. Running test_ssl on 2.7 with 1.0.1g I do have a failure: == ERROR: test_socketserver (test.test_ssl.ThreadedTests) Using a SocketServer to create and manage SSL connections. -- Traceback (most recent call last): File P:\ath\to\2.7\cpython\lib\test\test_ssl.py, line 1179, in test_socketserver f = urllib.urlopen(url) File P:\ath\to\2.7\cpython\lib\urllib.py, line 87, in urlopen return opener.open(url) File P:\ath\to\2.7\cpython\lib\urllib.py, line 208, in open return getattr(self, name)(url) File P:\ath\to\2.7\cpython\lib\urllib.py, line 437, in open_https h.endheaders(data) File P:\ath\to\2.7\cpython\lib\httplib.py, line 969, in endheaders self._send_output(message_body) File P:\ath\to\2.7\cpython\lib\httplib.py, line 829, in _send_output self.send(msg) File P:\ath\to\2.7\cpython\lib\httplib.py, line 791, in send self.connect() File P:\ath\to\2.7\cpython\lib\httplib.py, line 1176, in connect self.sock = ssl.wrap_socket(sock, self.key_file, self.cert_file) File P:\ath\to\2.7\cpython\lib\ssl.py, line 392, in wrap_socket ciphers=ciphers) File P:\ath\to\2.7\cpython\lib\ssl.py, line 148, in __init__ self.do_handshake() File P:\ath\to\2.7\cpython\lib\ssl.py, line 310, in do_handshake self._sslobj.do_handshake() IOError: [Errno socket error] [Errno 1] _ssl.c:510: error:140770FC:SSL routines: SSL23_GET_SERVER_HELLO:unknown protocol -- But this looks closely related to a failure that I have on this machine using 3.4 (which is probably the fault of the way this network is set up): == ERROR: test_socketserver (test.test_ssl.ThreadedTests) Using a SocketServer to create and manage SSL connections. -- Traceback (most recent call last): File P:\ath\to\3.4\cpython\lib\urllib\request.py, line 1189, in do_open h.request(req.get_method(), req.selector, req.data, headers) File P:\ath\to\3.4\cpython\lib\http\client.py, line 1090, in request self._send_request(method, url, body, headers) File P:\ath\to\3.4\cpython\lib\http\client.py, line 1128, in _send_request self.endheaders(body) File P:\ath\to\3.4\cpython\lib\http\client.py, line 1086, in endheaders self._send_output(message_body) File P:\ath\to\3.4\cpython\lib\http\client.py, line 924, in _send_output self.send(msg) File P:\ath\to\3.4\cpython\lib\http\client.py, line 859, in send self.connect() File P:\ath\to\3.4\cpython\lib\http\client.py, line 1221, in connect super().connect() File P:\ath\to\3.4\cpython\lib\http\client.py, line 839, in connect self._tunnel() File P:\ath\to\3.4\cpython\lib\http\client.py, line 822, in _tunnel message.strip())) OSError: Tunnel connection failed: 403 Forbidden During handling of the above exception, another exception occurred: Traceback (most recent call last): File P:\ath\to\3.4\cpython\lib\test\test_ssl.py,line 2315, in test_socketserver f = urllib.request.urlopen(url) File P:\ath\to\3.4\cpython\lib\urllib\request.py, line 153, in urlopen return opener.open(url, data, timeout) File P:\ath\to\3.4\cpython\lib\urllib\request.py, line 455, in open response = self._open(req, data) File P:\ath\to\3.4\cpython\lib\urllib\request.py, line 473, in _open '_open', req) File P:\ath\to\3.4\cpython\lib\urllib\request.py, line 433, in _call_chain result = func(*args) File P:\ath\to\3.4\cpython\lib\urllib\request.py, line 1230, in https_open context=self._context, check_hostname=self._check_hostname) File P:\ath\to\3.4\cpython\lib\urllib\request.py, line 1192, in do_open raise URLError(err) urllib.error.URLError: urlopen error Tunnel connection failed: 403 Forbidden -- As such, I'll leave it to someone else to properly test this before committing. -- keywords: +patch nosy: +zach.ware Added file: http://bugs.python.org/file35200/issue21462.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Steve Dower added the comment: I just tried it and had no trouble building and running the ssl tests on Windows. python Lib\test\regrtest.py -u network -v test_ssl ... Ran 38 tests in 7.700s OK (skipped=2) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Zachary Ware added the comment: Thanks, Steve. Nick, I assume 1.0.1g is the target version? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21462] PEP 466: upgrade OpenSSL in the Python 2.7 Windows builds
Tim Golden added the comment: Builds tests ok here on a fresh checkout (of cpython openssl-1.0.1g) -- nosy: +tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21462 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
