Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21934
___
Roundup Robot added the comment:
New changeset 354c3b65e245 by Serhiy Storchaka in branch '2.7':
Issue #21934: test_file2k no longer create regular file /dev/full on OpenBSD
https://hg.python.org/cpython/rev/354c3b65e245
--
nosy: +python-dev
___
Antoine Pitrou added the comment:
Why the complication? You could just use open mode r+.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21934
___
Serhiy Storchaka added the comment:
This was my first idea. But this would be different test. The behavior of files
opened with w and r+ modes can be different.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21934
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21934
___
Ezio Melotti added the comment:
If it's not needed in other places, I think the proposed patch might be OK
(assuming it works fine on other platforms).
--
nosy: +ezio.melotti
stage: - patch review
versions: +Python 3.4, Python 3.5
___
Python
Mark Lawrence added the comment:
The patch is against test_file2k.py which I can't find in my default cpython
setup. If this was removed from (say) Python 3.0 how do I check for that?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
I tried to grep on 3.x for this test but it looks like it's been removed there,
so this issue only affects 2.7.
--
versions: -Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
Daniel Dickman added the comment:
We will merge any fix decided by the python team when it's committed. In the
meantime may commit our fix on OpenBSD to solve the problem in the short term
as it seems no one has time to go further right now.
--
___
New submission from Daniel Dickman:
There is no /dev/full device on OpenBSD. If you run the 2.7 regress tests as
root on OpenBSD, a /dev/full regular file will be created and the
test_write_full test will fail. (because the subsequent write will succeed in
writing to the /dev/full regular
Changes by Daniel Dickman didick...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file35885/python.dev.full.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21934
___
STINNER Victor added the comment:
I would prefer a decorator checking if a device exists, something like:
@requires_character_device('/dev/full')
It would always skip on Windows. Implement it in test_support.py.
--
nosy: +haypo
___
Python tracker
12 matches
Mail list logo