[issue21983] segfault in ctypes.cast

[STINNER Victor]

STINNER Victor  added the comment:

> Still needs a backport to 2.7

No longer needed, I close the issue.

--
nosy: +vstinner
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Steve Dower]

Change by Steve Dower :


--
assignee: steve.dower -> 
stage: patch review -> backport needed
versions:  -Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Steve Dower]

Steve Dower  added the comment:

Still needs a backport to 2.7

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[miss-islington]

miss-islington  added the comment:


New changeset e60f6e1864d80d80f8928afadec617d161a64150 by Miss Islington (bot) 
in branch '3.7':
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structured data 
type (GH-3859)
https://github.com/python/cpython/commit/e60f6e1864d80d80f8928afadec617d161a64150


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[miss-islington]

miss-islington  added the comment:


New changeset 8ac158a6dfb86880e22003afe0ff39ec31b0a094 by Miss Islington (bot) 
in branch '3.6':
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structured data 
type (GH-3859)
https://github.com/python/cpython/commit/8ac158a6dfb86880e22003afe0ff39ec31b0a094


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Steve Dower]

Steve Dower  added the comment:

The backport to 2.7 needs some help. I can't do it on my laptop for the next 
week, but I'll try to get to it eventually. Feel free to get there first.

--
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[miss-islington]

Change by miss-islington :


--
pull_requests: +6434

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[miss-islington]

Change by miss-islington :


--
pull_requests: +6433
stage: backport needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Steve Dower]

Change by Steve Dower :


--
assignee:  -> steve.dower
stage: patch review -> backport needed
versions: +Python 3.8 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Steve Dower]

Steve Dower  added the comment:


New changeset d518d8bc8d5dac1a1270612f424d33e0e5afc2b5 by Steve Dower (Oren 
Milman) in branch 'master':
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structured data 
type (GH-3859)
https://github.com/python/cpython/commit/d518d8bc8d5dac1a1270612f424d33e0e5afc2b5


--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Oren Milman]

Change by Oren Milman :


--
versions: +Python 2.7, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Oren Milman]

Change by Oren Milman :


--
versions: +Python 3.7 -Python 2.7, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Oren Milman]

Change by Oren Milman :


--
keywords: +patch
pull_requests: +3839
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Oren Milman]

Oren Milman  added the comment:

IMHO, Lib/ctypes/test/test_cast.py is the relevant test.

Mark, do you still wish to provide a fix for that?
(Otherwise, i would be happy to open a PR.)

--
nosy: +Oren Milman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Mark Lawrence]

Mark Lawrence added the comment:

I'll provide a patch but I don't know which test file to use, can somebody 
please advise.

--
nosy: +BreamoreBoy, amaury.forgeotdarc, belopolsky, meador.inge

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21983
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Anthony LaTorre]

New submission from Anthony LaTorre:

I get a segfault when trying to cast a string to a structure. 
 import ctypes
 class Struct(ctypes.Structure):
... _fields_ = [('a', ctypes.c_uint32)]
... 
 s = '0'*100
 ctypes.cast(s,Struct)
Segmentation fault

The docs (https://docs.python.org/2/library/ctypes.html#ctypes.cast) say that 
`obj` must be an object that can be interpreted as a pointer, so I assume 
this should return the same exception you get when trying to cast a list:

 ctypes.cast(range(10),Struct)
Traceback (most recent call last):
  File stdin, line 1, in module
  File /usr/local/lib/python3.4/ctypes/__init__.py, line 488, in cast
return _cast(obj, obj, typ)
ctypes.ArgumentError: argument 1: class 'TypeError': wrong type

--
messages: 223062
nosy: Anthony.LaTorre
priority: normal
severity: normal
status: open
title: segfault in ctypes.cast
type: crash
versions: Python 2.7, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21983
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[Anthony LaTorre]

Changes by Anthony LaTorre tlator...@gmail.com:


--
components: +ctypes

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21983
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21983] segfault in ctypes.cast

[eryksun]

eryksun added the comment:

You need to cast to a pointer type, i.e. POINTER(Struct). Trying to cast to 
just Struct should raise a TypeError. Instead this revealed a bug in 
cast_check_pointertype (3.4.1):

http://hg.python.org/cpython/file/c0e311e010fc/Modules/_ctypes/_ctypes.c#l5225

dict-proto is NULL in the Struct type's stgdict, so 
PyUnicode_Check(dict-proto) segfaults. A simple fix is to add a check for this 
on line 5235:

if (dict  dict-proto) {

Then cast will raise the expected TypeError from line 5242 on return from line 
5255.

--
nosy: +eryksun

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21983
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com