Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: commit review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
Roundup Robot added the comment:
New changeset a5cb10f2dbaa by Raymond Hettinger in branch '2.7':
Issue #21990: Cleanup unnecessary inner class definition in saxutils.
http://hg.python.org/cpython/rev/a5cb10f2dbaa
--
nosy: +python-dev
___
Python
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
Eric V. Smith added the comment:
Looks fine to me. Normally I'd define the class being returned before the
function returning it, but it doesn't really make a difference.
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
LGTM. But it would be better to add underscore prefix to class name.
--
nosy: +serhiy.storchaka
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
New submission from Alex Gaynor:
This makes things slower than they need to be (yes, even on CPython :-)), and
is slightly confusing since usually inner classes are only used when a closure
is needed.
Attached patch simply moves the class definition.
--
components: Library (Lib)
Changes by Ned Deily n...@acm.org:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing
Changes by Alex Gaynor alex.gay...@gmail.com:
--
keywords: +needs review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
