[issue21990] saxutils defines an inner class where a normal one would do

2014-07-27 Thread Berker Peksag 

Changes by Berker Peksag berker.pek...@gmail.com:


--
stage: commit review - resolved

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-25 Thread Raymond Hettinger 

Changes by Raymond Hettinger raymond.hettin...@gmail.com:


--
assignee:  - rhettinger
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-25 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset a5cb10f2dbaa by Raymond Hettinger in branch '2.7':
Issue #21990:  Cleanup unnecessary inner class definition in saxutils.
http://hg.python.org/cpython/rev/a5cb10f2dbaa

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-25 Thread Raymond Hettinger 

Changes by Raymond Hettinger raymond.hettin...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-23 Thread Eric V. Smith 

Eric V. Smith added the comment:

Looks fine to me. Normally I'd define the class being returned before the 
function returning it, but it doesn't really make a difference.

--
nosy: +eric.smith

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-23 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

LGTM. But it would be better to add underscore prefix to class name.

--
nosy: +serhiy.storchaka
stage:  - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-16 Thread Alex Gaynor 

New submission from Alex Gaynor:

This makes things slower than they need to be (yes, even on CPython :-)), and 
is slightly confusing since usually inner classes are only used when a closure 
is needed.

Attached patch simply moves the class definition.

--
components: Library (Lib)
files: sax.diff
keywords: patch
messages: 223209
nosy: alex
priority: normal
severity: normal
status: open
title: saxutils defines an inner class where a normal one would do
versions: Python 2.7
Added file: http://bugs.python.org/file35970/sax.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-16 Thread Ned Deily 

Changes by Ned Deily n...@acm.org:


--
nosy: +christian.heimes

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21990] saxutils defines an inner class where a normal one would do

2014-07-16 Thread Alex Gaynor 

Changes by Alex Gaynor alex.gay...@gmail.com:


--
keywords: +needs review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com