[issue22083] Refactor PyShell's breakpoint related methods

[Tal Einat]

Change by Tal Einat :


--
nosy:  -taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22083] Refactor PyShell's breakpoint related methods

[Saimadhav Heblikar]

Saimadhav Heblikar added the comment:

This patch does two things

1. Refactor pyshell-breakpoint-refactor.diff to reflect changes in 
pyshell-breakpoint-refactor.diff

As in pyshell-breakpoint-refactor.diff, the set/clear(_here) breakpoint methods 
are refactored into logical methods.

2. If the filename is not set, text.bell() is replaced with a dialog to prompt 
the user to save the file.

--
Added file: http://bugs.python.org/file36348/pyshell-breakpoint-refactor-v2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22083
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22083] Refactor PyShell's breakpoint related methods

[Terry J. Reedy]

Terry J. Reedy added the comment:

The _here methods are the event handlers for the right click context menu 
options. Set_breakpoint, as a separate method, is only needed in the 
restore_file_breaks (from breakpoint file) method. I gather that you are 
thinking of using set/clear_breakpoint when a line number is clicked.

You have elsewhere suggested a different refactoring - replacing set and clear 
with toggle. That seems plausible as a good idea.  If text will have no 
breakpoints set after 
   self.text.update() # this enables setting BREAK tags to be visible
in restore_file_breaks(), there would be no problem. If not, toggle would need 
a force_set option. We need to know when the circumstances of when 
restore_file_breaks is called.

The bell is both undependable and uniformative. If breakpoints are not allowed 
for unnamed files, the context menu items should be grayed out (if possible, as 
done, for instance, for 'cut' when there is no selectionj).  If a line numbers 
is clicked for unnamed, we should display a message box explaining.

--
stage:  - needs patch
type:  - enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22083
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22083] Refactor PyShell's breakpoint related methods

[Saimadhav Heblikar]

New submission from Saimadhav Heblikar:

This refactoring is required to enable setting/clearing breakpoints, using 
linenumbering( whether using a Canvas implementation or a Text implementation 
http://bugs.python.org/issue17535)
The patch ensures consistency between the set_breakpoint(_here) and
clear_breakpoint(_here) methods. The clear_breakpoint_here, which is not 
present currently has been added.
No functionality has been added or removed, so I think it should be safe to go 
forward.

--
components: IDLE
files: pyshell-breakpoint-refactor.diff
keywords: patch
messages: 224062
nosy: jesstess, sahutd, taleinat, terry.reedy
priority: normal
severity: normal
status: open
title: Refactor PyShell's breakpoint related methods
versions: Python 2.7, Python 3.4, Python 3.5
Added file: http://bugs.python.org/file36112/pyshell-breakpoint-refactor.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22083
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com