[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pitrou]

Antoine Pitrou  added the comment:


New changeset 019f5b3e9e4c2a1297580483c3d5a5a10bddb93b by Antoine Pitrou 
(Antoine Pietri) in branch 'master':
bpo-22674: fix test_strsignal on OSX (GH-6085)
https://github.com/python/cpython/commit/019f5b3e9e4c2a1297580483c3d5a5a10bddb93b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pitrou]

Change by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Ned Deily]

Ned Deily  added the comment:

> Ned, this is why I'd like issue33048 to be solved :-) Having to rely on the 
> buildbot fleet for bugfix iteration is not convenient at all.

I want to see it solved, too. :-)  But there are other core-devs out there who 
are in a better position to solve it at the moment; it's not particularly a 
macOS problem; it's a problem with using Homebrew and Travis, neither one of 
which I'm all that familiar with and which others have set up.  And I'm in the 
middle of trying to get some releases and other stuff out the door.  So, I'm 
not going to be able to spend time on it right now.  Sorry!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pietri]

Antoine Pietri  added the comment:

Done, https://github.com/python/cpython/pull/6085

As I said in the PR body, I can't test it myself, I don't have an OSX VM setup.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pietri]

Change by Antoine Pietri :


--
pull_requests: +5846
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> Should I submit a new PR for this?

Please do.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pietri]

Antoine Pietri  added the comment:

Yes, sorry, the issue is that we decided with pitrou to remove the osx specific 
handling.

The fix should be:

diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py
index fbb12a5b67..ae0351e992 100644
--- a/Lib/test/test_signal.py
+++ b/Lib/test/test_signal.py
@@ -58,8 +58,10 @@ class PosixTests(unittest.TestCase):
 self.assertEqual(signal.getsignal(signal.SIGHUP), hup)
 
 def test_strsignal(self):
-self.assertEqual(signal.strsignal(signal.SIGINT), "Interrupt")
-self.assertEqual(signal.strsignal(signal.SIGTERM), "Terminated")
+self.assertTrue(signal.strsignal(signal.SIGINT)
+.startswith("Interrupt"))
+self.assertTrue(signal.strsignal(signal.SIGTERM)
+.startswith("Terminated"))
 
 # Issue 3864, unknown if this affects earlier versions of freebsd also
 def test_interprocess_signal(self):


Should I submit a new PR for this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Ned, this is why I'd like issue33048 to be solved :-) Having to rely on the 
buildbot fleet for bugfix iteration is not convenient at all.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Ned Deily]

Ned Deily  added the comment:

test_strsignal is failing on macOS.

==
FAIL: test_strsignal (test.test_signal.PosixTests)
--
Traceback (most recent call last):
  File 
"/Users/nad/Projects/PyDev/active/dev/3x/source/Lib/test/test_signal.py", line 
61, in test_strsignal
self.assertEqual(signal.strsignal(signal.SIGINT), "Interrupt")
AssertionError: 'Interrupt: 2' != 'Interrupt'
- Interrupt: 2
?  ---
+ Interrupt


Also:
http://buildbot.python.org/all/#/builders/14/builds/779/steps/4/logs/stdio
http://buildbot.python.org/all/#/builders/93/builds/435/steps/4/logs/stdio

--
nosy: +ned.deily
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pitrou]

Antoine Pitrou  added the comment:

This is now pushed.  Thank you Antoine!

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pitrou]

Change by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pietri]

Antoine Pietri  added the comment:

I updated Vajrasky's patch to rebase it onto master, use the clinic argument 
parser and improve the docs. I made a PR on GitHub so the review can be easier 
than a patch.

I left a Co-Authored-By field so I'm not stealing the ownership of this patch 
:-P

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Antoine Pietri]

Change by Antoine Pietri :


--
pull_requests: +5784
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[Chris Rebert]

Change by Chris Rebert :


--
nosy: +cvrebert

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22674] RFE: Add signal.strsignal(): string describing a signal

[STINNER Victor]

STINNER Victor  added the comment:

> 3. For the unknown signal, what is the description should be? "Unknown 
> signal" like c function returns or None?

Hum, Linux returns "Unknown signal 12345". I propose to use this behaviour on 
all platforms (which provide strsignal()).

--
title: strsignal() missing from signal module -> RFE: Add signal.strsignal(): 
string describing a signal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com