[issue23062] test_argparse --version test cases

Serhiy Storchaka added the comment: I should agree with you. Then the patch LGTM. -- assignee: -> berker.peksag stage: patch review -> commit review ___ Python tracker ___ _

[issue23062] test_argparse --version test cases

Martin Panter added the comment: Serhiy, there is already a test for that: class TestHelpVersionAction(HelpTestCase): """Test the default help for the version action""" So I still think the test is redundant, unless it is made to exercise help=SUPPRESS, as Berker’s patch does. --

[issue23062] test_argparse --version test cases

Serhiy Storchaka added the comment: But it already was between two help tests: TestHelpNoHelpOptional and TestHelpNone. I think that original test tested that the help attribute is optional for the --version argument and default description is printed in help output. This test shouldn't be re

[issue23062] test_argparse --version test cases

Berker Peksag added the comment: > Why the test class is moved? Just wanted to group all TestHelp* tests together. -- ___ Python tracker ___

[issue23062] test_argparse --version test cases

Serhiy Storchaka added the comment: Why the test class is moved? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-lis

[issue23062] test_argparse --version test cases

Martin Panter added the comment: Patch looks sensible enough to me -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue23062] test_argparse --version test cases

Berker Peksag added the comment: I think that your analysis is correct. Also, looks like the original test is problematic: https://code.google.com/p/argparse/source/browse/test/test_argparse.py#3710 Here is a patch to fix the test. -- keywords: +patch nosy: +berker.peksag, bethard, pa

[issue23062] test_argparse --version test cases

New submission from Martin Panter: In Lib/test/test_argparse.py: class TestHelpVersionOptional(HelpTestCase): """Test that the --version argument can be suppressed help messages""" Assuming that the docstring means something like “. . . can be suppressed _in_ help messages”, the test is wr