[issue23076] list(pathlib.Path().glob("")) fails with IndexError

Changes by Zachary Ware : -- hgrepos: -331 ___ Python tracker ___ ___

[issue23076] list(pathlib.Path().glob("")) fails with IndexError

Roundup Robot added the comment: New changeset 35bf4f9e68f3 by Berker Peksag in branch '3.5': Issue #23076: Path.glob() now raises a ValueError if it's called with an https://hg.python.org/cpython/rev/35bf4f9e68f3 New changeset 0a6290195f7c by Berker Peksag in branch 'default': Issue #23076:

[issue23076] list(pathlib.Path().glob("")) fails with IndexError

Berker Peksag added the comment: Thanks for the patch, Thomas! > Though I've been reading the developer guide, I'm a bit unfamiliar with the > process here so I'm not totally sure I'm doing this right. You did everything right :) I just tweaked the test a bit. > I created the patch relative

[issue23076] list(pathlib.Path().glob("")) fails with IndexError

Thomas Nyberg added the comment: I added a patch which causes glob to raise a ValueError exception if it is called with an empty string. I also added a test verifying the change and have run all the tests and they pass. Though I've been reading the developer guide, I'm a bit unfamiliar with

[issue23076] list(pathlib.Path().glob()) fails with IndexError

liu chang added the comment: hi pitrou, should we fix it in _make_selector(pattern_parts) function? origin code as: def _make_selector(pattern_parts): pat = pattern_parts[0] child_parts = pattern_parts[1:] if pat == '**': cls = _RecursiveWildcardSelector elif '**' in

[issue23076] list(pathlib.Path().glob()) fails with IndexError

Arfrever Frehtes Taifersar Arahesis added the comment: list(pathlib.Path().glob()) Traceback (most recent call last): File stdin, line 1, in module File /usr/lib64/python3.5/pathlib.py, line 999, in glob selector = _make_selector(tuple(pattern_parts)) File