Roundup Robot added the comment:
New changeset 9a7d965ab80f by Serhiy Storchaka in branch '3.4':
Issue #23268: Fixed bugs in the comparison of ipaddress classes.
https://hg.python.org/cpython/rev/9a7d965ab80f
New changeset 051f2a234d8a by Serhiy Storchaka in branch 'default':
Issue #23268:
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23268
Changes by Serhiy Storchaka storch...@gmail.com:
--
dependencies: +delegation of `!=` to the right-hand side argument is not always
done
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23268
Nick Coghlan added the comment:
+1, looks good to me.
That test for ordering and comparison interoperability is actually pretty neat
- I wonder if we could make it more generally available as a check my class
handles NotImplemented correctly check (in unittest?), which would potentially
be
Serhiy Storchaka added the comment:
The fact the default __ne__ implementation doesn't handle NotImplemented
correctly should probably be filed as a separate issue.
May be this is a part of issue21408.
--
___
Python tracker rep...@bugs.python.org
New submission from Serhiy Storchaka:
Here is a patch which fixes following errors in comparison of ipaddress classes.
1. Ordering comparison raised AttributeError when compared with foreign classes.
2. Ordering comparison didn't return NotImplemented when compared with foreign
classes. This
