Serhiy Storchaka added the comment:
Thank you for your patch Swapneel, but this issue was fixed in issue25758.
--
nosy: +serhiy.storchaka
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow, superluser
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23327
___
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
type: crash - behavior
versions: +Python 3.5, Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23327
___
Swapneel Ambre added the comment:
Attaching a combined patch. I updated testUnencodable testcase from
test_zipimport.py. Verified that without my fix, the testcase fails and it
passes with my fix.
--
Added file: http://bugs.python.org/file37883/zipimport_fix_withtest.patch
STINNER Victor added the comment:
Please see zipimport_fix.patch for the possible fix.
The solution looks good. Can you please try to convert zipimport_test.py to a
patch for test_zipimport.py and combine it with zipimport_fix.patch to
create a complete patch?
You should also sign the
STINNER Victor added the comment:
I do agree that it is a corner case scenario and using ASCII names is a
better option :-)
Since the patch is short, I see no problem to fix this issue.
--
___
Python tracker rep...@bugs.python.org
New submission from Swapneel Ambre:
On Windows, using zipimport module APIs like get_filename on a file with
non-ascii characters in the full path fails with
UnicodeEncodeError: 'mbcs' codec can't encode characters in position 0--1:
invalid character ( Full output attached in errorlog.txt ).
Swapneel Ambre added the comment:
I have tried to fix this by calling Py_CompileStringObject instead of
Py_CompileString , thus avoiding the need to Encode the pathname. Please see
zipimport_fix.patch for the possible fix.
--
keywords: +patch
Added file:
Swapneel Ambre added the comment:
I am attaching the test script I have used to reproduce the issue.
--
Added file: http://bugs.python.org/file37873/zipimport_test.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23327
STINNER Victor added the comment:
I don't understand the issue: does it only concern the name of the ZIP file? Or
also paths inside the ZIP?
In both cases, the workaround is to use only ASCII names.
I spent a lot of times on supporting any Unicode name, everyone in Python. I
didn't expect
Swapneel Ambre added the comment:
Sorry I was not very clear about the use case.
The name of the zipfile or any parent directory name could contain non-ascii
characters. Consider a use case where you want to ship some product with third
party module shipped as an egg file (say example.egg)
11 matches
Mail list logo
