Berker Peksag added the comment:
Committed now. Thanks for the patch, Martin and thanks for the review, Demian.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 21b31f5438ae by Berker Peksag in branch '3.4':
Issue #23439: Add missing entries to http.client.__all__.
https://hg.python.org/cpython/rev/21b31f5438ae
New changeset 95533c9edaaf by Berker Peksag in branch 'default':
Issue #23439: Add missing
Martin Panter added the comment:
Posting v3 patch that changes from a list to a set of expected API names
--
Added file: http://bugs.python.org/file38180/http.client-all.v3.patch
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
Left a super minor comment in Rietveld, but otherwise LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23439
___
Martin Panter added the comment:
Posting a new patch which explicitly omits HTTPMessage, parse_headers(), and
the status codes. Also added and documented the LineTooLong exception. It is
already somewhat covered in the test suite.
See also Issue 21257 about the status of parse_headers().
Martin Panter added the comment:
I don’t have a strong opinion about changing __all__ in these cases. I only
noticed the potential problem when I went to add a new class to the module, and
thought this was common practice. If we leave it as it is, it would be good to
add comment in the source
Demian Brecht added the comment:
If we leave it as it is, it would be good to add comment in the source code
explaining this decision.
I think that __all__ should be left as-is for the time being. Adding
some comments around that decision makes sense to me to avoid any future
confusion around
Martin Panter added the comment:
Actually, maybe I should add all those status codes as well, like
http.client.OK. Will probably require different patches for 3.4 and 3.5.
--
___
Python tracker rep...@bugs.python.org
Changes by Demian Brecht demianbre...@gmail.com:
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23439
___
___
Berker Peksag added the comment:
It's not that important in my opinion. Let's keep it simple for now :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23439
___
Demian Brecht added the comment:
The only real question I have is: why? As far as I'm aware, these are
implementation details of the http.client module (there's even a comment in
HTTPMessage that it might make sense to move the class altogether).
As far as the constants go, they're only there
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
stage: - patch review
versions: +Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23439
___
Changes by Martin Panter vadmium...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file38090/http.client-all.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23439
___
New submission from Martin Panter:
This patch was split off my patch for Issue 3566, since it should be less
controversial. It adds the HTTPMessage class and the parse_headers() function
to __all__.
I’m not too sure on the status of the parse_headers() function. It is not
mentioned in the
14 matches
Mail list logo