[issue23447] Import fails when doing a circular import involving an `import *`

Brett Cannon added the comment: I talked the semantic change over with Eric at the core sprint and we are both iffy enough on the semantic change and how it will impact stuff that we don't feel comfortable accepting the patch. Sorry, Steven, but thanks for taking a stab at it. --

[issue23447] Import fails when doing a circular import involving an `import *`

Steven Barker added the comment: Thanks for looking at the issue Brett. I think you're right that your patch has incorrect semantics, since it doesn't save the value to the provided namespace if it had to go through the special path to find the name. I think my patch got that part right

[issue23447] Import fails when doing a circular import involving an `import *`

Brett Cannon added the comment: Just so Steven knows, I'm still thinking about whether I want to accept the patch (and waiting to see if anyone else has an opinion =). I did realize that the patch as it stands does not add the found module as an attribute on the package which is potentially

[issue23447] Import fails when doing a circular import involving an `import *`

Brett Cannon added the comment: Here is Steven's patch touched up. I still have not decided if the semantic change is worth it. If anyone else has an opinion please feel free to speak up. All tests do pass, though, so it at least doesn't seem to directly break anything. -- Added

[issue23447] Import fails when doing a circular import involving an `import *`

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___

[issue23447] Import fails when doing a circular import involving an `import *`

Steven Barker added the comment: I've managed to partially fix my build environment, so I can verify that my patch (attached previously) works as intended. I'm not completely sure that it doesn't break unrelated things as my build still has lots of failing tests (which all appear to be

[issue23447] Import fails when doing a circular import involving an `import *`

Robert Collins added the comment: Yep: The issue has no clear solution , e.g., no agreement on a technical solution or if it is even a problem worth fixing. Brett is saying he doesn't consider this a bug. Steven says he doesn't have time to push it forward. Oh, I see there is a patch

[issue23447] Import fails when doing a circular import involving an `import *`

Mark Lawrence added the comment: Languishing? :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23447 ___ ___ Python-bugs-list mailing list

[issue23447] Import fails when doing a circular import involving an `import *`

Mark Lawrence added the comment: Can someone reset the status and open fields, thanks. -- nosy: +BreamoreBoy versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23447 ___

[issue23447] Import fails when doing a circular import involving an `import *`

Robert Collins added the comment: reset. -- nosy: +rbcollins resolution: not a bug - stage: - needs patch status: closed - languishing ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23447

[issue23447] Import fails when doing a circular import involving an `import *`

Steven Barker added the comment: I've finally gotten around to looking into this issue and it turns out that fixing from package import * to work with circular imports is pretty easy, as all that needs to be done is apply the same logic from the patch for issue 17636 to the loop in the next

[issue23447] Import fails when doing a circular import involving an `import *`

Brett Cannon added the comment: If you want to take a stab at it, Steven, go for it and I will review the patch, but as you pointed out this is such an edge case that I'm personally not going to worry about fixing it and still don't consider it a bug. -- title: Relative imports with