[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-04-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1b509a7e3b99 by Victor Stinner in branch '2.7': Issue #23458: Remove test_os.test_urandom_fd_non_inheritable() https://hg.python.org/cpython/rev/1b509a7e3b99 -- ___ Python tracker rep...@bugs.python.org

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-04-06 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-30 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- resolution: fixed - stage: resolved - needs patch status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The test_urandom_fd_non_inheritable is constantly failed on AMD64 OpenIndiana 2.7 buildbot. http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%202.7/builds/2727/steps/test/logs/stdio

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-17 Thread Ned Deily
Ned Deily added the comment: FD_CLOEXEC is first support on OS X 10.5. Here's a patch to skip the test on earlier systems: tested on 10.4, 10.5, and 10.10. -- nosy: +ned.deily stage: - commit review Added file: http://bugs.python.org/file38516/issue23458_tiger.patch

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-17 Thread STINNER Victor
STINNER Victor added the comment: Ned Deily added the comment: FD_CLOEXEC is first support on OS X 10.5. Here's a patch to skip the test on earlier systems: tested on 10.4, 10.5, and 10.10. What do you mean by first support? Does it mean that fcntl(fd, F_SETFD, FD_CLOEXEC) is simply a

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-17 Thread Ned Deily
Ned Deily added the comment: The buildbot is now green - closed. -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 730bbd1499ba by Ned Deily in branch '2.7': Issue #23458: Skip test_urandom_fd_non_inheritable on OS X 10.4 since https://hg.python.org/cpython/rev/730bbd1499ba -- ___ Python tracker

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-17 Thread Ned Deily
Ned Deily added the comment: $ sw_vers ProductName:Mac OS X ProductVersion: 10.4.11 BuildVersion: 8S165 $ ./python Python 3.4.3+ (3.4:910a7a540a31, Mar 17 2015, 03:33:01) [GCC 4.0.1 (Apple Computer, Inc. build 5370)] on darwin Type help, copyright, credits or license for more information.

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-03-17 Thread STINNER Victor
STINNER Victor added the comment: Ok, so Python 3.4 works as expected on Mac OS X 10.4. It's probably because Python 3.4 uses ioctl() if available. Maybe ioctl() works, but not fcntl(). os.urandom() only *tries* to make the file descriptor non-inheritable. It would be possible to backport

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-28 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___ ___

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-20 Thread Ed Maste
Changes by Ed Maste carpedd...@gmail.com: -- nosy: +Ed.Maste ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___ ___ Python-bugs-list mailing

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-20 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___ ___

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-20 Thread Ed Maste
Ed Maste added the comment: For reference, this fd leak was causing one of LLDB's tests to fail. It is now marked XFAIL pending a resolution of this issue: http://llvm.org/viewvc/llvm-project?view=revisionrevision=229704 Linux is also affected, the Linux LLDB tests were previously running on

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: +0 This seems like a reasonable change with some upside and no obvious downside. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-13 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- versions: +Python 2.7 -Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-13 Thread STINNER Victor
New submission from STINNER Victor: Attached patch tries to make the private random file descriptor non-inheritable. It should fix the following issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197376 I tried to write an unit test, but since the PEP 446 is not implemented, unexpected

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-13 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: Added file: http://bugs.python.org/file38127/test_fd_status.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-13 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +koobs ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23458 ___ ___ Python-bugs-list

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm not sure what the point is - there are many child descriptors which may inherited, why care about this one? The right way to avoid this on 2.7 is to call subprocess.Popen(..., close_fds=True). -- ___ Python

[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-02-13 Thread STINNER Victor
STINNER Victor added the comment: I'm not sure what the point is - there are many child descriptors which may inherited, why care about this one? The bug report comes from FreeBSD, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197376 They use os.system(), at least in the bug report.