[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:

Thanks all!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[miss-islington]

miss-islington  added the comment:


New changeset af3685963652721269ca0196f9f7fc08d3e830b7 by Miss Islington (bot) 
in branch '2.7':
bpo-23495: Correct the documentation for writerows() of csv Writer objects 
(GH-6316)
https://github.com/python/cpython/commit/af3685963652721269ca0196f9f7fc08d3e830b7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[miss-islington]

miss-islington  added the comment:


New changeset 949da9e44b4e0d5b32745b91f9582158442b68d1 by Miss Islington (bot) 
in branch '3.7':
bpo-23495: Correct the documentation for writerows() of csv Writer objects 
(GH-6316)
https://github.com/python/cpython/commit/949da9e44b4e0d5b32745b91f9582158442b68d1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[miss-islington]

miss-islington  added the comment:


New changeset db3039085845af5d68ab863f03e9684681b1516d by Miss Islington (bot) 
in branch '3.6':
bpo-23495: Correct the documentation for writerows() of csv Writer objects 
(GH-6316)
https://github.com/python/cpython/commit/db3039085845af5d68ab863f03e9684681b1516d


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[miss-islington]

Change by miss-islington :


--
pull_requests: +6971

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[miss-islington]

Change by miss-islington :


--
pull_requests: +6970

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[miss-islington]

Change by miss-islington :


--
pull_requests: +6969

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:


New changeset a801cf164be7c62b6a6dba47ff91d6c3edb67729 by Mariatta (Zackery 
Spytz) in branch 'master':
bpo-23495: Correct the documentation for writerows() of csv Writer objects 
(GH-6316)
https://github.com/python/cpython/commit/a801cf164be7c62b6a6dba47ff91d6c3edb67729


--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Nathaniel Manista]

Change by Nathaniel Manista :


--
nosy: +Nathaniel Manista

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Zackery Spytz]

Zackery Spytz  added the comment:

Commit 7901b48a1f89b9bfa9d111ae3725400b466a9baa removed the unnecessary list 
conversion (3.5+), but the documentation issue remains.

--
nosy: +ZackerySpytz
versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +6032
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Martijn Pieters]

Martijn Pieters added the comment:

I'd be happy to provide a patch for the DictWriter.writerows code; I was 
naively counting on it accepting an iterable and that it would not pull the 
whole sequence into memory (while feeding it gigabytes of CSV data).

--
nosy: +mjpieters

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23495
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Peter Otten]

Changes by Peter Otten __pete...@web.de:


--
nosy: +peter.otten

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23495
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[SilentGhost]

Changes by SilentGhost ghost@gmail.com:


--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23495
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[R. David Murray]

R. David Murray added the comment:

Seems reasonable to me.  Do you want to prepare patches?  The doc patch should 
be separate, since it applies to all active versions, but the code change to 
dictwriter would go only into 3.5.

--
stage:  - needs patch
versions:  -Python 3.2, Python 3.3, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23495
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Steven Barker]

New submission from Steven Barker:

The documentation for the csv.writer.writerows method says that it expects a 
list of row objects, when it really will accept any iterable that yields rows 
(such as a generator). While it's often nice for code to be more accepting than 
the documented requirements, I think the docs in this case should state that 
writerows() expects an iterable, rather than misinforming users that a list is 
required.

This documentation issue was brought up in a Stack Overflow question here: 
http://stackoverflow.com/questions/28636848/csv-writer-writerows-takes-iterator

I expect the necessary documentation patch will be pretty trivial, and if 
nobody else gets to it first, I will try to provide one when I have enough time 
to update my cpython checkout (not soon, alas).

--
assignee: docs@python
components: Documentation
messages: 236328
nosy: Steven.Barker, docs@python
priority: normal
severity: normal
status: open
title: The writer.writerows method should be documented as accepting any 
iterable (not only a list)
type: enhancement
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23495
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23495] The writer.writerows method should be documented as accepting any iterable (not only a list)

[Steven Barker]

Steven Barker added the comment:

Another Stack Overflow user pointed out that the DictWriter's writerows 
implementation (in pure Python) unnecessarily converts whatever its argument is 
into a list in memory before passing it on to the builtin writer.writerows 
method which would accept any iterable type. Probably it should be changed to 
use map or a generator expression instead.

So, perhaps this issue isn't purely documentation, but actually a small 
behavior enhancement as well.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23495
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com