[issue23773] importlib does not properly remove frames when invoking external import hooks

Changes by Brett Cannon : -- assignee: brett.cannon -> ___ Python tracker ___ ___

[issue23773] importlib does not properly remove frames when invoking external import hooks

Brett Cannon added the comment: Did you happen to run the test suite with this change, Shiz? There's actually a test to make sure that the part of the traceback you're avoiding isn't lost in case there's a bug in importlib itself. Can you show that your change won't actually affect finding

[issue23773] importlib does not properly remove frames when invoking external import hooks

Changes by Raúl Cumplido raulcumpl...@gmail.com: -- nosy: +raulcd ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23773 ___ ___ Python-bugs-list

[issue23773] importlib does not properly remove frames when invoking external import hooks

Shiz added the comment: Ah, that is a very good point. I'll run the suite as soon as I find the time and will report back. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23773 ___

[issue23773] importlib does not properly remove frames when invoking external import hooks

Changes by Ned Deily n...@acm.org: -- nosy: +brett.cannon stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23773 ___ ___

[issue23773] importlib does not properly remove frames when invoking external import hooks

Changes by Brett Cannon br...@python.org: -- assignee: - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23773 ___ ___

[issue23773] importlib does not properly remove frames when invoking external import hooks

New submission from Shiz: When adding a custom module loader to sys.meta_path, importlib does not properly remove its frames before invoking it. This results in a weird traceback with importlib._bootstrap frames in if an error occurs during load_module(), like such: Traceback (most recent