[issue23856] build.bat -e shouldn't also build

[Tim Golden]

New submission from Tim Golden:

PCBuild\build.bat takes an argument of -e to pull in external libraries. 

Either by accident or by design the main build will run in addition. However if 
you'd run pcbuild -e simply to pull in externals, you might not have specified 
extra build params, such as -d or -p x64.

The attached patch naively drops out after get_externals has been called; other 
possibilities might include carrying on if -e was not the only parameter.

--
components: Windows
files: build-externals.patch
keywords: patch
messages: 239957
nosy: steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: build.bat -e shouldn't also build
type: behavior
versions: Python 3.5
Added file: http://bugs.python.org/file38813/build-externals.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23856
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23856] build.bat -e shouldn't also build

[Tim Golden]

Tim Golden added the comment:

Fair enough

--
resolution:  - not a bug
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23856
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23856] build.bat -e shouldn't also build

[Zachary Ware]

Zachary Ware added the comment:

 Either by accident or by design the main build will run in addition.

By design; I intended get_externals.bat to be run explicitly if you just
wanted to pull the externals.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23856
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com