[issue23885] urllib.quote horribly mishandles unicode as second parameter

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23885] urllib.quote horribly mishandles unicode as second parameter

[Zackery Spytz]

Zackery Spytz  added the comment:

Python 2 is EOL, so I think this issue should be closed.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23885] urllib.quote horribly mishandles unicode as second parameter

[Michael Sander]

Michael Sander  added the comment:

Couldn't this be fixed in a backwards compatible way by clearing the cache when 
this type of error occurs? We can do this by wrapping the offending line with a 
try/except, then checking to see if the cache is corrupted. If it is, then we 
clear the cache and try again.

try:
  if not s.rstrip(safe):
return s
except UnicodeDecodeError:
  # Make sure the cache is okay, if not, try again.
  if any([not isinstance(s2, str) for q2, s2 in _safe_quoters.values()])
# Cache is corrupted, clear it and try again.
 _safe_quoters = {}
# Recursive call to try again
return quote(s, safe)
  raise

--
nosy: +Michael Sander

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23885] urllib.quote horribly mishandles unicode as second parameter

[Ezio Melotti]

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
nosy: +ezio.melotti, orsenthil
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23885
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23885] urllib.quote horribly mishandles unicode as second parameter

[Marcin Kościelnicki]

New submission from Marcin Kościelnicki:

All hell breaks loose when unicode is passed as the second argument to 
urllib.quote in Python 2:

 import urllib
 urllib.quote('\xce\x91', u'')
Traceback (most recent call last):
  File stdin, line 1, in module
  File /usr/lib/python2.7/urllib.py, line 1292, in quote
if not s.rstrip(safe):
UnicodeDecodeError: 'ascii' codec can't decode byte 0xce in position 0: ordinal 
not in range(128)

This on its own wouldn't be that bad - just another Python 2 unicode wonkiness. 
 However, coupled with caching done by the quote function (quoters are cached 
based on the second parameter, and u'' == ''), it means that a random preceding 
call to quote from an entirely different place in the application can break 
your code:

$ python2
Python 2.7.9 (default, Dec 11 2014, 04:42:00)
[GCC 4.9.2] on linux2
Type help, copyright, credits or license for more information.
 import urllib
 urllib.quote('\xce\x91', '')
'%CE%91'



$ python2
Python 2.7.9 (default, Dec 11 2014, 04:42:00)
[GCC 4.9.2] on linux2
Type help, copyright, credits or license for more information.
 import urllib
 urllib.quote('a', u'')
'a'
 urllib.quote('\xce\x91', '')
Traceback (most recent call last):
  File stdin, line 1, in module
  File /usr/lib/python2.7/urllib.py, line 1292, in quote
if not s.rstrip(safe):
UnicodeDecodeError: 'ascii' codec can't decode byte 0xce in position 0: ordinal 
not in range(128)

Good luck debugging that.

So, one of two things needs to happen:

- a TypeError when unicode is passed as the second parameter, or
- a cast of the second parameter to str

--
components: Library (Lib)
messages: 240230
nosy: koriakin
priority: normal
severity: normal
status: open
title: urllib.quote horribly mishandles unicode as second parameter
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23885
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23885] urllib.quote horribly mishandles unicode as second parameter

[R. David Murray]

R. David Murray added the comment:

The typerror isn't going to happen for backward compatibility reasons.  A fix 
isn't likely to happen because python2 doesn't really support unicode in 
urllib, to my understanding (if I'm wrong about that the answser changes).  I'm 
not sure whether casting to string would have backward compatibility issues or 
not (I suspect it would; somneone would have to investigate that question as a 
first step).

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23885
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com