[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[miss-islington]

miss-islington  added the comment:


New changeset 447fdd178f1007294db38bf0392a0cf74a49d460 by Miss Islington (bot) 
in branch '3.7':
bpo-24318: Rewrite the README PGO section. (GH-6863)
https://github.com/python/cpython/commit/447fdd178f1007294db38bf0392a0cf74a49d460


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[Gregory P. Smith]

Change by Gregory P. Smith :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[miss-islington]

Change by miss-islington :


--
pull_requests: +6577

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 93f9a8a5afb58b1d2e4f27bb46d3d4e0fa8c08f0 by Gregory P. Smith in 
branch 'master':
bpo-24318: Rewrite the README PGO section. (#6863)
https://github.com/python/cpython/commit/93f9a8a5afb58b1d2e4f27bb46d3d4e0fa8c08f0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[Gregory P. Smith]

Change by Gregory P. Smith :


--
pull_requests: +6537

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[miss-islington]

Change by miss-islington :


--
pull_requests: +6236

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[miss-islington]

Change by miss-islington :


--
pull_requests: +6235

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[Gregory P. Smith]

Gregory P. Smith  added the comment:

FYI - The test suite minus some of the crazier tests (multiprocessing) that the 
makefile uses today is the recommended workload and is effectively what linux 
distros I've looked at use.

It is a myth that the specific application workload matters a great deal for 
building a Python PGO interpreter.  The layer of indirection provided by an 
interpreter makes it easier.  All you really need is code that exercises the 
major important C speed paths.  The eval loop, unicode internals, long bignum 
internals, marshal, re, pickle, json, xml, and cdecimal are all well exercised 
by running the test suite.

A specific Python application's actual logic is not going to exercise the 
internals of those in a meaningfully different manner.

Performance experiments bear this out.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[Gregory P. Smith]

Change by Gregory P. Smith :


--
pull_requests: +6234
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[Joachim Wagner]

Joachim Wagner  added the comment:

The readme in 3.6.5 has a section on PGO but the sentence "If ran,
``make profile-opt`` will do several steps." can be misunderstood that one has 
to run this command instead of "make" after "configure --enable-optimizations". 
Furthermore, a 2015 post suggests that most Linux distributions use a different 
workload than the one provided for much better results. The readme should talk 
about this, either clarifying that this issue has been resolved or making 
recommendations for the workload. (I understand that licence incompatibilities 
or the size of the workload may be reasons for not including the recommended 
workload in the source distribution.)

--
nosy: +jwagner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[R. David Murray]

R. David Murray added the comment:

Agreed with Greg, this should not be the default.  Changing title and component 
to reflect that better documentation is the goal here.

--
assignee:  - docs@python
components: +Documentation -Build
nosy: +docs@python, r.david.murray
stage:  - needs patch
title: Make profile-opt the default Make target? - Better documentaiton of 
profile-opt (and release builds in general?)
versions: +Python 3.4, Python 3.5 -Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24318
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24318] Better documentaiton of profile-opt (and release builds in general?)

[Skip Montanaro]

Skip Montanaro added the comment:

Thanks. The doc change occurred to me while I was composing my ticket. It 
wasn't obvious at that time that profile-opt shouldn't be the default (though I 
was carrying on an email conversation with Greg at about the same time).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24318
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com